From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0CB5C6786F for ; Thu, 1 Nov 2018 07:38:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 90ADF2064C for ; Thu, 1 Nov 2018 07:38:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 90ADF2064C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728072AbeKAQj7 (ORCPT ); Thu, 1 Nov 2018 12:39:59 -0400 Received: from mx2.suse.de ([195.135.220.15]:38538 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727846AbeKAQj7 (ORCPT ); Thu, 1 Nov 2018 12:39:59 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id E2C62AEC2; Thu, 1 Nov 2018 07:38:08 +0000 (UTC) Date: Thu, 01 Nov 2018 08:38:08 +0100 Message-ID: From: Takashi Iwai To: Cc: , "Hui Wang" , "Jaroslav Kysela" , "KailangYang" , Subject: Re: [PATCH 2/3] ALSA:hda: fix front speakers on Huawei MBXP. In-Reply-To: <60bede7d2cc0a0c06575da2bcbf06367f15bf4ca.camel@gmail.com> References: <20181031192013.7701-1-ayman.bagabas@gmail.com> <60bede7d2cc0a0c06575da2bcbf06367f15bf4ca.camel@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/26 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 31 Oct 2018 21:08:18 +0100, wrote: > > This patch solves bug 200501 'Only 2 of 4 speakers playing sound.' > https://bugzilla.kernel.org/show_bug.cgi?id=200501 The information should be put in the patch description. thanks, Takashi > > On Wed, 2018-10-31 at 15:20 -0400, Ayman Bagabas wrote: > > This patch enables the front speakers on Huawei Matebook X Pro > > laptops. > > These laptops come with Dolby Atmos sound system and these pins > > configuration enables the front speakers. > > > > Signed-off-by: Ayman Bagabas > > --- > > sound/pci/hda/patch_realtek.c | 18 ++++++++++++++++++ > > 1 file changed, 18 insertions(+) > > > > diff --git a/sound/pci/hda/patch_realtek.c > > b/sound/pci/hda/patch_realtek.c > > index 3ac7ba9b342d..4f7a39c7883c 100644 > > --- a/sound/pci/hda/patch_realtek.c > > +++ b/sound/pci/hda/patch_realtek.c > > @@ -5493,6 +5493,7 @@ enum { > > ALC298_FIXUP_TPT470_DOCK, > > ALC255_FIXUP_DUMMY_LINEOUT_VERB, > > ALC255_FIXUP_DELL_HEADSET_MIC, > > + ALC256_FIXUP_HUAWEI_MBXP_PINS, > > ALC295_FIXUP_HP_X360, > > ALC221_FIXUP_HP_HEADSET_MIC, > > }; > > @@ -6347,6 +6348,22 @@ static const struct hda_fixup alc269_fixups[] > > = { > > .chained = true, > > .chain_id = ALC269_FIXUP_HEADSET_MIC > > }, > > + [ALC256_FIXUP_HUAWEI_MBXP_PINS] = { > > + .type = HDA_FIXUP_PINS, > > + .v.pins = (const struct hda_pintbl[]) { > > + {0x12, 0x90a60130}, > > + {0x13, 0x40000000}, > > + {0x14, 0x90170110}, > > + {0x18, 0x411111f0}, > > + {0x19, 0x04a11040}, > > + {0x1a, 0x411111f0}, > > + {0x1b, 0x90170112}, > > + {0x1d, 0x40759a05}, > > + {0x1e, 0x411111f0}, > > + {0x21, 0x04211020}, > > + { }, > > + }, > > + }, > > [ALC295_FIXUP_HP_X360] = { > > .type = HDA_FIXUP_FUNC, > > .v.func = alc295_fixup_hp_top_speakers, > > @@ -6592,6 +6609,7 @@ static const struct snd_pci_quirk > > alc269_fixup_tbl[] = { > > SND_PCI_QUIRK(0x17aa, 0x5109, "Thinkpad", > > ALC269_FIXUP_LIMIT_INT_MIC_BOOST), > > SND_PCI_QUIRK(0x17aa, 0x511e, "Thinkpad", > > ALC298_FIXUP_TPT470_DOCK), > > SND_PCI_QUIRK(0x17aa, 0x511f, "Thinkpad", > > ALC298_FIXUP_TPT470_DOCK), > > + SND_PCI_QUIRK(0x19e5, 0x3204, "Huawei MBXP", > > ALC256_FIXUP_HUAWEI_MBXP_PINS), > > SND_PCI_QUIRK(0x17aa, 0x3bf8, "Quanta FL1", > > ALC269_FIXUP_PCM_44K), > > SND_PCI_QUIRK(0x17aa, 0x9e54, "LENOVO NB", > > ALC269_FIXUP_LENOVO_EAPD), > > SND_PCI_QUIRK(0x1b7d, 0xa831, "Ordissimo EVE2 ", > > ALC269VB_FIXUP_ORDISSIMO_EVE2), /* Also known as Malata PC-B1303 */ > >