From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933002Ab3BLJY0 (ORCPT ); Tue, 12 Feb 2013 04:24:26 -0500 Received: from cantor2.suse.de ([195.135.220.15]:40502 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758445Ab3BLJYY (ORCPT ); Tue, 12 Feb 2013 04:24:24 -0500 Date: Tue, 12 Feb 2013 10:24:23 +0100 Message-ID: From: Takashi Iwai To: Fernando Luis =?UTF-8?B?VsOhenF1ZXo=?= Cao Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] ALSA: hda - update documentation for no-primary-hp fixup In-Reply-To: <1360655386.13766.4.camel@nexus.lab.ntt.co.jp> References: <1360655264.13766.2.camel@nexus.lab.ntt.co.jp> <1360655386.13766.4.camel@nexus.lab.ntt.co.jp> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Tue, 12 Feb 2013 16:49:46 +0900, Fernando Luis Vázquez Cao wrote: > > The problem addressed by this fixup is not specific to Vaio Z, affecting > some Vaio all-in-one desktop PCs too. Update the code comments accordingly. > > Cc: stable@vger.kernel.org > Cc: alsa-devel@alsa-project.org > Signed-off-by: Fernando Luis Vazquez Cao I applied this now to sound git tree but dropped Cc to stable because the patch is no longer cleanly applicable due to the recent code change. And this is just some minor documentation update, thus we can still live peacefully without this fix. thanks, Takashi > --- > > diff -urNp linux-3.7.6-orig/Documentation/sound/alsa/HD-Audio-Models.txt linux-3.7.6/Documentation/sound/alsa/HD-Audio-Models.txt > --- linux-3.7.6-orig/Documentation/sound/alsa/HD-Audio-Models.txt 2012-12-11 12:30:57.000000000 +0900 > +++ linux-3.7.6/Documentation/sound/alsa/HD-Audio-Models.txt 2013-02-09 22:44:28.614772054 +0900 > @@ -53,7 +53,7 @@ ALC882/883/885/888/889 > acer-aspire-8930g Acer Aspire 8330G/6935G > acer-aspire Acer Aspire others > inv-dmic Inverted internal mic workaround > - no-primary-hp VAIO Z workaround (for fixed speaker DAC) > + no-primary-hp VAIO Z/VGC-LN51JGB workaround (for fixed speaker DAC) > > ALC861/660 > ========== > diff -urNp linux-3.7.6-orig/sound/pci/hda/patch_realtek.c linux-3.7.6/sound/pci/hda/patch_realtek.c > --- linux-3.7.6-orig/sound/pci/hda/patch_realtek.c 2013-02-09 22:39:11.745202168 +0900 > +++ linux-3.7.6/sound/pci/hda/patch_realtek.c 2013-02-09 22:50:10.924470402 +0900 > @@ -5153,7 +5153,8 @@ static void alc889_fixup_imac91_vref(str > } > > /* Don't take HP output as primary > - * strangely, the speaker output doesn't work on VAIO Z through DAC 0x05 > + * Strangely, the speaker output doesn't work on Vaio Z and some Vaio > + * all-in-one desktop PCs (for example VGC-LN51JGB) through DAC 0x05 > */ > static void alc882_fixup_no_primary_hp(struct hda_codec *codec, > const struct alc_fixup *fix, int action) > >