From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id D58A8C433DB
	for <linux-kernel@archiver.kernel.org>; Wed, 24 Feb 2021 08:00:41 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 879D864ED1
	for <linux-kernel@archiver.kernel.org>; Wed, 24 Feb 2021 08:00:41 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S233956AbhBXIAV (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Wed, 24 Feb 2021 03:00:21 -0500
Received: from mx2.suse.de ([195.135.220.15]:41012 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S233912AbhBXH6N (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 24 Feb 2021 02:58:13 -0500
X-Virus-Scanned: by amavisd-new at test-mx.suse.de
Received: from relay2.suse.de (unknown [195.135.221.27])
        by mx2.suse.de (Postfix) with ESMTP id 267D1AD2B;
        Wed, 24 Feb 2021 07:57:29 +0000 (UTC)
Date:   Wed, 24 Feb 2021 08:57:28 +0100
Message-ID: <s5hczwpucd3.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     George Harker <george@george-graphics.co.uk>
Cc:     alsa-devel@alsa-project.org, Clemens Ladisch <clemens@ladisch.de>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sound/usb generate midi streaming substream names from jack names
In-Reply-To: <20210221094333.30499-1-george@george-graphics.co.uk>
References: <20210221094148.30447-1-george@george-graphics.co.uk>
        <20210221094333.30499-1-george@george-graphics.co.uk>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, 21 Feb 2021 10:43:32 +0100,
George Harker wrote:
> 
> A number of devices have named substreams which are hard to remember /
> decypher from <device> MIDI n names.  Eg. Korg puts a pass through on
> one substream and iConnectivity devices name the connections.
> 
> This makes it easier to connect to the correct device.  Devices which
> handle naming through quirks are unaffected by this change.
> 
> Addresses TODO comment in sound/usb/midi.c
> 
> Signed-off-by: George Harker <george@george-graphics.co.uk>

The code changes look almost OK, but could you try the following?

- Split the patch: one for rewriting with the structs in
  linux/usb/midi.h, another for adding the MIDI device name support

- Try to avoid magic numbers: a few places should be replaced with
  sizeof() or ARRAY_SIZE().


thanks,

Takashi