From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B5E6C2D0DC for ; Thu, 2 Jan 2020 15:13:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 388A8206E6 for ; Thu, 2 Jan 2020 15:13:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728668AbgABPNZ (ORCPT ); Thu, 2 Jan 2020 10:13:25 -0500 Received: from mx2.suse.de ([195.135.220.15]:49532 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728561AbgABPNY (ORCPT ); Thu, 2 Jan 2020 10:13:24 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 021ECB0BE; Thu, 2 Jan 2020 15:13:22 +0000 (UTC) Date: Thu, 02 Jan 2020 16:13:21 +0100 Message-ID: From: Takashi Iwai To: Julia Lawall Cc: Jaroslav Kysela , kernel-janitors@vger.kernel.org, Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/10] ALSA: ml403-ac97cr: use resource_size In-Reply-To: References: <1577900990-8588-1-git-send-email-Julia.Lawall@inria.fr> <1577900990-8588-3-git-send-email-Julia.Lawall@inria.fr> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 01 Jan 2020 20:23:24 +0100, Julia Lawall wrote: > > On Wed, 1 Jan 2020, Takashi Iwai wrote: > > > On Wed, 01 Jan 2020 18:49:42 +0100, > > Julia Lawall wrote: > > > > > > Use resource_size rather than a verbose computation on > > > the end and start fields. > > > > > > The semantic patch that makes this change is as follows: > > > (http://coccinelle.lip6.fr/) > > > > > > > > > @@ struct resource *ptr; @@ > > > - ((ptr->end) - (ptr->start) + 1) > > > + resource_size(ptr) > > > > > > > > > Signed-off-by: Julia Lawall > > > > Unfortunately this doesn't apply cleanly on my tree. I guess you > > worked on linux-next which contains a change outside the sound git > > tree that converts ioremap_nocache() to ioremap(). > > > > We may apply it in sound git tree and let conflicts resolved at the > > merge time. OTOH, it's no urgent fix at all and can be postponed > > after 5.6-rc1 merge, too -- then everything can be applied in a > > cleaner way. > > > > Let me know your preference. > > It's from linux-next. No hurry. Postponing it is fine. OK, let's postpone this. Thanks. Takashi