From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A3F3C433F5 for ; Mon, 10 Sep 2018 09:16:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 20EEB204FD for ; Mon, 10 Sep 2018 09:16:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 20EEB204FD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727860AbeIJOJN (ORCPT ); Mon, 10 Sep 2018 10:09:13 -0400 Received: from mx2.suse.de ([195.135.220.15]:38306 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726081AbeIJOJN (ORCPT ); Mon, 10 Sep 2018 10:09:13 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 808BAAEFC; Mon, 10 Sep 2018 09:16:07 +0000 (UTC) Date: Mon, 10 Sep 2018 11:16:07 +0200 Message-ID: From: Takashi Iwai To: Greg Kroah-Hartman Cc: Stefan Wahren , Eric Anholt , linux-rpi-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 00/29] staging: bcm2835-audio: Cleanups and fixes In-Reply-To: <20180910091236.GB21533@kroah.com> References: <20180904155858.8001-1-tiwai@suse.de> <2050605805.39126.1536412690563@email.1und1.de> <20180910091236.GB21533@kroah.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/26 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 10 Sep 2018 11:12:36 +0200, Greg Kroah-Hartman wrote: > > On Sat, Sep 08, 2018 at 06:21:55PM +0200, Takashi Iwai wrote: > > On Sat, 08 Sep 2018 15:18:10 +0200, > > Stefan Wahren wrote: > > > > > > Hi Takashi, > > > > > > > Takashi Iwai hat am 4. September 2018 um 17:58 geschrieben: > > > > > > > > > > > > Hi, > > > > > > > > since I had an opportunity to play with RPi3B+ recently, I took a look > > > > at the existing bcm2835-audio driver code and was amused very much :) > > > > > > > > So here is the result, a cleanup and fix patch series. > > > > > > > > Most of the patches are trivial cleanups, just brushing up, removing > > > > many redundant and buggy codes, as well as code simplifications. > > > > > > > > A big functional change is that now it uses non-atomic PCM ops, so > > > > that we can kill the ugly workqueue usages. Also, the resource > > > > management was simplified. > > > > > > first of all, thank you very much for this series. > > > > > > Eric has no time as maintainer, so i will try to give you some feedback (beware of very little audio driver knowledge). > > > > > > I functionally tested your patch series on a Raspberry Pi 1 B (bcm2835_defconfig), so this whole series is at least: > > > > > > Tested-by: Stefan Wahren > > > > OK, thanks, I'll put to my series in case of resubmission. > > Meanwhile I'll keep the series in topic/vc04 branch of sound.git > > tree. > > I'll just take this through my tree now, so there aren't merge issues if > there happens to be other cleanups to the driver that show up in the > near future. OK, thanks! Takashi