From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753027AbdK2Igz (ORCPT <rfc822;w@1wt.eu>);
        Wed, 29 Nov 2017 03:36:55 -0500
Received: from mx2.suse.de ([195.135.220.15]:38093 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750849AbdK2Igx (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 29 Nov 2017 03:36:53 -0500
Date: Wed, 29 Nov 2017 09:36:50 +0100
Message-ID: <s5hd141pjkt.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: " Maciej S. Szmigiero " <mail@maciej.szmigiero.name>
Cc: "Nicolin Chen" <nicoleotsuka@gmail.com>,
        "Xiubo Li" <Xiubo.Lee@gmail.com>, "Jaroslav Kysela" <perex@perex.cz>,
        "Timur Tabi" <timur@tabi.org>, <alsa-devel@alsa-project.org>,
        "Liam Girdwood" <lgirdwood@gmail.com>,
        "Mark Brown" <broonie@kernel.org>, <linuxppc-dev@lists.ozlabs.org>,
        "Fabio Estevam" <fabio.estevam@nxp.com>,
        "Takashi Sakamoto" <o-takashi@sakamocchi.jp>,
        "linux-kernel" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 1/2] ALSA: pcm: add SNDRV_PCM_FORMAT_{S,U}20
In-Reply-To: <3a279ea2-8098-d5a4-a53e-b0e3585fa9bf@maciej.szmigiero.name>
References: <3a279ea2-8098-d5a4-a53e-b0e3585fa9bf@maciej.szmigiero.name>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 27 Nov 2017 23:33:29 +0100,
 Maciej S. Szmigiero  wrote:
> 
> This format is similar to existing SNDRV_PCM_FORMAT_{S,U}20_3 that keep
> 20-bit PCM samples in 3 bytes, however i.MX6 platform SSI FIFO does not
> allow 3-byte accesses (including DMA) so a 4-byte (more conventional)
> format is needed for it.
> 
> Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
> ---
> Changes from v1: Drop "_4" suffix from these formats since they aren't
> non-standard ones, use empty format slots starting from format number 25
> for them, add information that they are LSB justified formats.
> 
> Changes from v2: Adapt a comment in sound/core/pcm_misc.c so it still
> refers to the same sample formats as before.
> 
> Changes from v3: Make the comment style in include/uapi/sound/asound.h
> match the style of comments at other sample formats.
> 
> Corresponding alsa-lib changes will be posted as soon as this patch is
> merged on the kernel side, to keep alsa-lib and kernel synchronized.

Applied to topic/pcm-20bit, also included in for-next.

Mark, please pull topic/pcm-20bit branch if you need to apply fsl_ssi
patch into your tree.


thanks,

Takashi