From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754467Ab3LRNGS (ORCPT ); Wed, 18 Dec 2013 08:06:18 -0500 Received: from cantor2.suse.de ([195.135.220.15]:52090 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752165Ab3LRNGQ (ORCPT ); Wed, 18 Dec 2013 08:06:16 -0500 Date: Wed, 18 Dec 2013 14:06:15 +0100 Message-ID: From: Takashi Iwai To: Henrique de Moraes Holschuh Cc: Lv Zheng , Len Brown , alsa-devel@alsa-project.org, ibm-acpi-devel@lists.sourceforge.net, "Rafael J. Wysocki" , Henrique de Moraes Holschuh , linux-kernel@vger.kernel.org, Lv Zheng , linux-acpi@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: Re: [alsa-devel] [RFC PATCH 15/15] ACPI/thinkpad: Fix wrong inclusion in Thinkpad ACPI users. In-Reply-To: <20131218114117.GB29631@khazad-dum.debian.net> References: <20131218114117.GB29631@khazad-dum.debian.net> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Wed, 18 Dec 2013 09:41:17 -0200, Henrique de Moraes Holschuh wrote: > > On Wed, 18 Dec 2013, Lv Zheng wrote: > > CONFIG_ACPI dependent code should include instead of > > directly including . This patch cleans up such wrong > > inclusions for Thinkpad ACPI users. > > ... > > > drivers/platform/x86/thinkpad_acpi.c | 1 - > > include/linux/thinkpad_acpi.h | 2 ++ > > sound/pci/hda/patch_conexant.c | 1 - > > sound/pci/hda/patch_realtek.c | 1 - > > I'd prefer if you left the include outside of thinkpad_acpi.h, and just fix > the include in the two ALSA users. Agreed. > We might add some extra stuff to thinkpad_acpi.h someday, and not everything > thinkpad_acpi does that might be useful to export to other areas of the > kernel would require acpi.h. > > Looking at patch_conexant and patch_realtek, it might be better to actually > move the "am I running on a thinkpad" stuff they use acpi.h for into > thinkpad_acpi, and provide a prototype for that in thinkpad_acpi.h. True, but we don't want to bind with thinkpad_acpi before identified that it's a thinkpad, so the code needs to be in hd-audio codec driver. thanks, Takashi