From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755325AbbFOMEj (ORCPT <rfc822;w@1wt.eu>);
	Mon, 15 Jun 2015 08:04:39 -0400
Received: from cantor2.suse.de ([195.135.220.15]:47555 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753930AbbFOMEb (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 15 Jun 2015 08:04:31 -0400
Date: Mon, 15 Jun 2015 14:04:30 +0200
Message-ID: <s5hegldgott.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Jonathan McDowell <noodles@earth.li>
Cc: Mihai =?UTF-8?B?RG9uyJt1?= <mihai.dontu@gmail.com>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: Audio crackles with 4.1-rc1
In-Reply-To: <20150614122420.GT28070@earth.li>
References: <s5hr3pjleac.wl-tiwai@suse.de>
	<20150610194303.3b82609d@mdontu-l.dsd.bitdefender.biz>
	<s5hy4jr8ltm.wl-tiwai@suse.de>
	<20150611011236.53bcd1fd@mdontu-l>
	<s5hioau96ue.wl-tiwai@suse.de>
	<20150612012318.6e3482ed@mdontu-l>
	<s5hy4jp5s3t.wl-tiwai@suse.de>
	<20150612124523.37fd0875@mdontu-l>
	<s5h8ubpjkzw.wl-tiwai@suse.de>
	<s5hk2v9hv5v.wl-tiwai@suse.de>
	<20150614122420.GT28070@earth.li>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

At Sun, 14 Jun 2015 13:24:20 +0100,
Jonathan McDowell wrote:
> 
> On Fri, Jun 12, 2015 at 04:13:16PM +0200, Takashi Iwai wrote:
> > At Fri, 12 Jun 2015 12:09:55 +0200,
> > Takashi Iwai wrote:
> > > At Fri, 12 Jun 2015 12:45:23 +0300,
> > > Mihai Donțu wrote:
> > > > Nice shot! It appears to work. :-) No clicks, no static.
> > > 
> > > Good to hear!
> > > 
> > > > I had to apply it by hand over 4.1-rc7, because the first two arrays
> > > > look different in both it and -master. Anyway, I will play with it some
> > > > more today see if anything else is broken.
> > > 
> > > While we are at it: could you try to enable codec->power_save_node in
> > > patch_alc269() (while keeping the new patch)?
> > > 
> > > --- a/sound/pci/hda/patch_realtek.c
> > > +++ b/sound/pci/hda/patch_realtek.c
> > > @@ -5671,8 +5671,7 @@ static int patch_alc269(struct hda_codec *codec)
> > >  
> > >  	spec = codec->spec;
> > >  	spec->gen.shared_mic_vref_pin = 0x18;
> > > -	if (codec->core.vendor_id != 0x10ec0292)
> > > -		codec->power_save_node = 1;
> > > +	codec->power_save_node = 1;
> > >  
> > >  #ifdef CONFIG_PM
> > >  	codec->patch_ops.suspend = alc269_suspend;
> > 
> > For your convenience, below is the combined patch for 4.1.
> > 
> > Jonathan, could you also try this patch and see whether you still get
> > the noise?
> 
> Applying the combined patch to 4.1-rc7 I'm not getting any noise on the
> transition from suspended to active.

Great, I queued the fix patch for 4.1-final now.


thanks,

Takashi