linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ALSA: usb-audio: Disable quirks for BOSS Katana amplifiers
@ 2019-10-11 17:19 Szabolcs Szőke
  2019-10-17  8:19 ` Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: Szabolcs Szőke @ 2019-10-11 17:19 UTC (permalink / raw)
  Cc: szszoke.code, Jaroslav Kysela, Takashi Iwai, Manuel Reinhardt,
	Mauro Carvalho Chehab, Ard van Breemen, Richard Fontana,
	Shuah Khan, Thomas Gleixner, alsa-devel, linux-kernel

BOSS Katana amplifiers cannot be used for recording or playback if quirks
are applied

BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=195223
Signed-off-by: Szabolcs Szőke <szszoke.code@gmail.com>

---
 sound/usb/pcm.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c
index 33cd26763c0e..daadb0c66eee 100644
--- a/sound/usb/pcm.c
+++ b/sound/usb/pcm.c
@@ -348,6 +348,9 @@ static int set_sync_ep_implicit_fb_quirk(struct snd_usb_substream *subs,
 		ep = 0x84;
 		ifnum = 0;
 		goto add_sync_ep_from_ifnum;
+	case USB_ID(0x0582, 0x01d8): /* BOSS Katana */
+		/* BOSS Katana amplifiers do not need quirks */
+		return 0;
 	}
 
 	if (attr == USB_ENDPOINT_SYNC_ASYNC &&
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ALSA: usb-audio: Disable quirks for BOSS Katana amplifiers
  2019-10-11 17:19 [PATCH] ALSA: usb-audio: Disable quirks for BOSS Katana amplifiers Szabolcs Szőke
@ 2019-10-17  8:19 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2019-10-17  8:19 UTC (permalink / raw)
  To: Szabolcs Szőke
  Cc: alsa-devel, Manuel Reinhardt, Mauro Carvalho Chehab, Shuah Khan,
	Ard van Breemen, Thomas Gleixner, Jaroslav Kysela,
	Richard Fontana, Takashi Iwai, linux-kernel

On Fri, 11 Oct 2019 19:19:36 +0200,
Szabolcs Szőke wrote:
> 
> BOSS Katana amplifiers cannot be used for recording or playback if quirks
> are applied
> 
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=195223
> Signed-off-by: Szabolcs Szőke <szszoke.code@gmail.com>

Applied now.  Thanks.


Takashi

> 
> ---
>  sound/usb/pcm.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c
> index 33cd26763c0e..daadb0c66eee 100644
> --- a/sound/usb/pcm.c
> +++ b/sound/usb/pcm.c
> @@ -348,6 +348,9 @@ static int set_sync_ep_implicit_fb_quirk(struct snd_usb_substream *subs,
>  		ep = 0x84;
>  		ifnum = 0;
>  		goto add_sync_ep_from_ifnum;
> +	case USB_ID(0x0582, 0x01d8): /* BOSS Katana */
> +		/* BOSS Katana amplifiers do not need quirks */
> +		return 0;
>  	}
>  
>  	if (attr == USB_ENDPOINT_SYNC_ASYNC &&
> -- 
> 2.20.1
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-10-17  8:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-11 17:19 [PATCH] ALSA: usb-audio: Disable quirks for BOSS Katana amplifiers Szabolcs Szőke
2019-10-17  8:19 ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).