From: Takashi Iwai <tiwai@suse.de>
To: "Hariprasad Kelam" <hariprasad.kelam@gmail.com>
Cc: <alsa-devel@alsa-project.org>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Geoff Levand" <geoff@infradead.org>,
"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
<linuxppc-dev@lists.ozlabs.org>,
"Jaroslav Kysela" <perex@perex.cz>,
"Paul Mackerras" <paulus@samba.org>,
"Takashi Iwai" <tiwai@suse.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sound: ppc: snd_ps3: Remove Unneeded variable: "ret"
Date: Wed, 10 Jul 2019 11:56:25 +0200 [thread overview]
Message-ID: <s5hftnerz5i.wl-tiwai@suse.de> (raw)
In-Reply-To: <20190710023946.GA15604@hari-Inspiron-1545>
On Wed, 10 Jul 2019 04:39:46 +0200,
Hariprasad Kelam wrote:
>
> This patch fixes below issue reported by coccicheck
> sound/ppc/snd_ps3.c:631:5-8: Unneeded variable: "ret". Return "0" on
> line 668
>
> We cannot change return type of snd_ps3_pcm_trigger as it is registered
> with snd_pcm_ops->trigger
>
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
Applied (with the correction of the description again).
thanks,
Takashi
prev parent reply other threads:[~2019-07-10 9:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-10 2:39 [PATCH] sound: ppc: snd_ps3: Remove Unneeded variable: "ret" Hariprasad Kelam
2019-07-10 9:56 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hftnerz5i.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=benh@kernel.crashing.org \
--cc=geoff@infradead.org \
--cc=hariprasad.kelam@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).