From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9793EECDFB8 for ; Wed, 18 Jul 2018 10:16:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 550A72084E for ; Wed, 18 Jul 2018 10:16:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 550A72084E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730255AbeGRKxn (ORCPT ); Wed, 18 Jul 2018 06:53:43 -0400 Received: from mx2.suse.de ([195.135.220.15]:56518 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726834AbeGRKxn (ORCPT ); Wed, 18 Jul 2018 06:53:43 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 6F107AF40; Wed, 18 Jul 2018 10:16:30 +0000 (UTC) Date: Wed, 18 Jul 2018 12:16:29 +0200 Message-ID: From: Takashi Iwai To: "Srikanth K H" Cc: , , , , , , , Subject: Re: [PATCH 1/1] Preventive fix in sound module In-Reply-To: <1531908468-1352-1-git-send-email-srikanth.h@samsung.com> References: <1531908468-1352-1-git-send-email-srikanth.h@samsung.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/26 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 18 Jul 2018 12:07:48 +0200, Srikanth K H wrote: > > Signed-off-by: Srikanth K H What does this fix, and above all, why is this needed? thanks, Takashi > --- > sound/core/timer.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/sound/core/timer.c b/sound/core/timer.c > index b6f076bb..c7be4f1 100644 > --- a/sound/core/timer.c > +++ b/sound/core/timer.c > @@ -1192,10 +1192,12 @@ static void snd_timer_proc_read(struct snd_info_entry *entry, > break; > case SNDRV_TIMER_CLASS_CARD: > snd_iprintf(buffer, "C%i-%i: ", > - timer->card->number, timer->tmr_device); > + timer->card ? timer->card->number : -1, > + timer->tmr_device); > break; > case SNDRV_TIMER_CLASS_PCM: > - snd_iprintf(buffer, "P%i-%i-%i: ", timer->card->number, > + snd_iprintf(buffer, "P%i-%i-%i: ", > + timer->card ? timer->card->number : -1, > timer->tmr_device, timer->tmr_subdevice); > break; > default: > -- > 1.9.1 > >