From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EF4FC43441 for ; Sun, 11 Nov 2018 08:44:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CCF52208A3 for ; Sun, 11 Nov 2018 08:44:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CCF52208A3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727550AbeKKScv (ORCPT ); Sun, 11 Nov 2018 13:32:51 -0500 Received: from mx2.suse.de ([195.135.220.15]:38332 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727393AbeKKScv (ORCPT ); Sun, 11 Nov 2018 13:32:51 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 6631DAACA; Sun, 11 Nov 2018 08:44:52 +0000 (UTC) Date: Sun, 11 Nov 2018 09:44:51 +0100 Message-ID: From: Takashi Iwai To: "Andy Shevchenko" Cc: "Ayman Bagabas" , "ALSA Development Mailing List" , "Hui Wang" , "Andy Shevchenko" , "Darren Hart" , "Jaroslav Kysela" , "Kailang Yang" , "Linux Kernel Mailing List" , "Platform Driver" Subject: Re: [PATCH v4 3/3] ALSA: hda: add support for Huawei WMI micmute LED In-Reply-To: References: <20181109234526.4280-1-ayman.bagabas@gmail.com> <20181109234526.4280-4-ayman.bagabas@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/26 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 10 Nov 2018 15:26:55 +0100, Andy Shevchenko wrote: > > On Sat, Nov 10, 2018 at 1:46 AM Ayman Bagabas wrote: > > > > Some of Huawei laptops come with a LED in the micmute key. This patch > > enables and disable this LED accordingly. > > This enables micmute LED for: > > 1. Matebook X (19e5:3200), (19e5:3201) > > 2. Matebook X Pro (19e5:3204) > > > > Signed-off-by: Ayman Bagabas > > --- > > sound/pci/hda/huawei_wmi_helper.c | 47 +++++++++++++++++++++++++++++++ > > sound/pci/hda/patch_realtek.c | 14 ++++++++- > > 2 files changed, 60 insertions(+), 1 deletion(-) > > create mode 100644 sound/pci/hda/huawei_wmi_helper.c > > > > diff --git a/sound/pci/hda/huawei_wmi_helper.c b/sound/pci/hda/huawei_wmi_helper.c > > new file mode 100644 > > index 000000000000..7c91f914ffba > > --- /dev/null > > +++ b/sound/pci/hda/huawei_wmi_helper.c > > @@ -0,0 +1,47 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* Helper functions for Huawei WMI micmute LED; > > + * to be included from codec driver > > + */ > > + > > > +#if IS_ENABLED(CONFIG_HUAWEI_LAPTOP) > > ENABLED or REACHABLE? FWIW, other similar codes take ENABLED. It's dynamic binding, and the codec driver may be re-bound even if it's a built-in. Takashi