From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C2EEC28CF6 for ; Wed, 1 Aug 2018 11:00:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 153CE2083D for ; Wed, 1 Aug 2018 11:00:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 153CE2083D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388867AbeHAMp0 (ORCPT ); Wed, 1 Aug 2018 08:45:26 -0400 Received: from mx2.suse.de ([195.135.220.15]:33824 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2388489AbeHAMpZ (ORCPT ); Wed, 1 Aug 2018 08:45:25 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 73C0FAF54; Wed, 1 Aug 2018 11:00:11 +0000 (UTC) Date: Wed, 01 Aug 2018 13:00:11 +0200 Message-ID: From: Takashi Iwai To: Pierre-Louis Bossart Cc: "Colin King" , , "Jaya Kumar" , "Liam Girdwood" , "Maxime Coquelin" , "Mark Brown" , , "Jaroslav Kysela" , "Alexandre Torgue" , "Arnaud Pouliquen" , "Olivier Moysan" , , Subject: Re: [PATCH 9/9] ALSA: intel_hdmi: remove redundant variable cfg_val In-Reply-To: <20180801104742.4328-10-colin.king@canonical.com> References: <20180801104742.4328-1-colin.king@canonical.com> <20180801104742.4328-10-colin.king@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/26 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 01 Aug 2018 12:47:42 +0200, Colin King wrote: > > From: Colin Ian King > > Variable cfg_val is being assigned but is never used hence it is > redundant and can be removed. > > Cleans up clang warning: > warning: variable 'cfg_val' set but not used [-Wunused-but-set-variable] > > Signed-off-by: Colin Ian King > --- > sound/x86/intel_hdmi_audio.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/sound/x86/intel_hdmi_audio.c b/sound/x86/intel_hdmi_audio.c > index edc9f5a34eff..fa7dca5a68c8 100644 > --- a/sound/x86/intel_hdmi_audio.c > +++ b/sound/x86/intel_hdmi_audio.c > @@ -290,7 +290,6 @@ static void had_reset_audio(struct snd_intelhad *intelhaddata) > static int had_prog_status_reg(struct snd_pcm_substream *substream, > struct snd_intelhad *intelhaddata) > { > - union aud_cfg cfg_val = {.regval = 0}; > union aud_ch_status_0 ch_stat0 = {.regval = 0}; > union aud_ch_status_1 ch_stat1 = {.regval = 0}; > > @@ -298,7 +297,6 @@ static int had_prog_status_reg(struct snd_pcm_substream *substream, > IEC958_AES0_NONAUDIO) >> 1; > ch_stat0.regx.clk_acc = (intelhaddata->aes_bits & > IEC958_AES3_CON_CLOCK) >> 4; > - cfg_val.regx.val_bit = ch_stat0.regx.lpcm_id; Actually this made me wonder what is the definition of val_bit. It seems always 1 in the current code after the commit 964ca8083c02. Pierre? thanks, Takashi