linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Jaroslav Kysela <perex@perex.cz>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] sound: sscape: add missing include of linux/io.h
Date: Wed, 28 Jan 2015 16:28:13 +0100	[thread overview]
Message-ID: <s5hiofqylf6.wl-tiwai@suse.de> (raw)
In-Reply-To: <3560329.35JVsOOFlQ@wuerfel>

At Wed, 28 Jan 2015 16:04:46 +0100,
Arnd Bergmann wrote:
> 
> The soundscape driver uses the ISA inb/outb functions declared
> in linux/io.h, so it needs to include this header to avoid
> a build error:
> 
> sscape.c: In function 'sscape_write_unsafe':
> sscape.c:203:2: error: implicit declaration of function 'outb' [-Werror=implicit-function-declaration]
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> Sorry about messing up the patch description the first time. I'm cleaning
> out old patches from a randconfig build tree and I found this one was
> still needed but did not inspect the changelog closely enough.

Thanks, applied.


Takashi

> 
> diff --git a/sound/isa/sscape.c b/sound/isa/sscape.c
> index 018ab140c2be..7b248cdf06e2 100644
> --- a/sound/isa/sscape.c
> +++ b/sound/isa/sscape.c
> @@ -23,6 +23,7 @@
>  
>  #include <linux/init.h>
>  #include <linux/err.h>
> +#include <linux/io.h>
>  #include <linux/isa.h>
>  #include <linux/delay.h>
>  #include <linux/firmware.h>
> 

      reply	other threads:[~2015-01-29  1:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-28 14:54 [PATCH] sound: sscape: add missing include of asm/io.h Arnd Bergmann
2015-01-28 14:56 ` Takashi Iwai
2015-01-28 15:04   ` [PATCH] sound: sscape: add missing include of linux/io.h Arnd Bergmann
2015-01-28 15:28     ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hiofqylf6.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).