From: Takashi Iwai <tiwai@suse.de>
To: Zheyu Ma <zheyuma97@gmail.com>
Cc: perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [BUG] ALSA: echoaudio: warning when the driver fails to probe
Date: Mon, 11 Apr 2022 09:41:06 +0200 [thread overview]
Message-ID: <s5hk0bwcbjh.wl-tiwai@suse.de> (raw)
In-Reply-To: <CAMhUBjm2AdyEZ_-EgexdNDN7SvY4f89=4=FwAL+c0Mg0O+X50A@mail.gmail.com>
On Sun, 10 Apr 2022 11:13:55 +0200,
Zheyu Ma wrote:
>
> Hello,
>
> I found a bug in echoaudio.c.
> When the driver fails at the function snd_echo_create(), it should
> release resources requested before, otherwise we will get the
> following warning:
>
> [ 3.262866] remove_proc_entry: removing non-empty directory
> 'irq/21', leaking at least 'snd_indigodj'
> [ 3.263577] WARNING: CPU: 3 PID: 261 at fs/proc/generic.c:717
> remove_proc_entry+0x389/0x3f0
> [ 3.267098] RIP: 0010:remove_proc_entry+0x389/0x3f0
> [ 3.269976] Call Trace:
> [ 3.269979] <TASK>
> [ 3.269988] unregister_irq_proc+0x14c/0x170
> [ 3.269997] irq_free_descs+0x94/0xe0
> [ 3.270004] mp_unmap_irq+0xb6/0x100
> [ 3.270011] acpi_unregister_gsi_ioapic+0x27/0x40
> [ 3.270017] acpi_pci_irq_disable+0x1d3/0x320
> [ 3.270025] pci_disable_device+0x1ad/0x380
> [ 3.270034] pcim_release+0x566/0x6d0
> [ 3.270046] devres_release_all+0x1f1/0x2c0
> [ 3.270057] really_probe+0xe0/0x920
Could you try the patch below?
thanks,
Takashi
---
--- a/sound/pci/echoaudio/echoaudio.c
+++ b/sound/pci/echoaudio/echoaudio.c
@@ -1906,9 +1906,6 @@ static int snd_echo_create(struct snd_card *card,
pci_write_config_byte(pci, PCI_LATENCY_TIMER, 0xC0);
- err = pcim_enable_device(pci);
- if (err < 0)
- return err;
pci_set_master(pci);
/* Allocate chip if needed */
@@ -1987,6 +1984,10 @@ static int snd_echo_probe(struct pci_dev *pci,
return -ENOENT;
}
+ err = pcim_enable_device(pci);
+ if (err < 0)
+ return err;
+
i = 0;
err = snd_devm_card_new(&pci->dev, index[dev], id[dev], THIS_MODULE,
sizeof(*chip), &card);
next prev parent reply other threads:[~2022-04-11 7:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-10 9:13 [BUG] ALSA: echoaudio: warning when the driver fails to probe Zheyu Ma
2022-04-11 7:41 ` Takashi Iwai [this message]
2022-04-11 8:49 ` Zheyu Ma
2022-04-11 9:06 ` Takashi Iwai
2022-04-11 9:15 ` Takashi Iwai
2022-04-11 10:30 ` Takashi Iwai
2022-04-11 10:34 ` Zheyu Ma
2022-04-11 15:14 ` Takashi Iwai
2022-04-12 1:36 ` Zheyu Ma
2022-04-12 9:28 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hk0bwcbjh.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=zheyuma97@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).