From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57304C4363A for ; Mon, 26 Oct 2020 15:22:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 258CE206E5 for ; Mon, 26 Oct 2020 15:22:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1783744AbgJZPWj (ORCPT ); Mon, 26 Oct 2020 11:22:39 -0400 Received: from mx2.suse.de ([195.135.220.15]:59400 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1783589AbgJZPWi (ORCPT ); Mon, 26 Oct 2020 11:22:38 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id AEB40B06A; Mon, 26 Oct 2020 15:22:36 +0000 (UTC) Date: Mon, 26 Oct 2020 16:22:36 +0100 Message-ID: From: Takashi Iwai To: Pierre-Louis Bossart Cc: Greg KH , linux-kernel@vger.kernel.org, stable-commits@vger.kernel.org, Takashi Iwai Subject: Re: Patch "ASoC: topology: disable size checks for bytes_ext controls if needed" has been added to the 4.9-stable tree In-Reply-To: References: <20201026055347.0F79E20882@mail.kernel.org> <20201026121123.GA2474358@kroah.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 26 Oct 2020 16:01:09 +0100, Pierre-Louis Bossart wrote: > > > > On 10/26/20 7:11 AM, Greg KH wrote: > > On Mon, Oct 26, 2020 at 01:53:46AM -0400, Sasha Levin wrote: > >> This is a note to let you know that I've just added the patch titled > >> > >> ASoC: topology: disable size checks for bytes_ext controls if needed > >> > >> to the 4.9-stable tree which can be found at: > >> http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > >> > >> The filename of the patch is: > >> asoc-topology-disable-size-checks-for-bytes_ext-cont.patch > >> and it can be found in the queue-4.9 subdirectory. > >> > >> If you, or anyone else, feels it should not be added to the stable tree, > >> please let know about it. > >> > > > > This breaks the build, so I'm dropping it from everywhere it had > > problems. > > > > Also, why 5.4.y and not 4.19.y, but 4.14.y and 4.9.y? > > Ah yes, there's a missed dependency on > fbd3eb7f66c5b ('ALSA: control: Add verification for kctl accesses') > > I thought all of this was 20 years old but that commit added the > option SND_CTL_VALIDATION which exposed the problem with this topology > patch. Given the date (January 2020), I don't think it makes sense > before 5.6? > > I don't think this could have compiled prior to 5.6, I e.g. checked on > 4.14.202 and the define SNDRV_CTL_ELEM_ACCESS_SKIP_CHECK was not > defined either. > > git grep SNDRV_CTL_ELEM_ACCESS_SKIP_CHECK > sound/soc/soc-topology.c: k->access |= > SNDRV_CTL_ELEM_ACCESS_SKIP_CHECK; > > Summary: I suggested this patch be dropped for all versions that don't > contain fbd3eb7f66c5b. Takashi, do you concur? Yes, correct. thanks, Takashi