Re: [PATCH v1 2/2] sound: Enable micmute led for Huawei laptops

From: Takashi Iwai <tiwai@suse.de>
To: "Ayman Bagabas" <ayman.bagabas@gmail.com>
Cc: <alsa-devel@alsa-project.org>,
	"Hui Wang" <hui.wang@canonical.com>,
	"Chris Chiu" <chiu@endlessm.com>,
	"Daniel Drake" <drake@endlessm.com>,
	"Jian-Hong Pan" <jian-hong@endlessm.com>,
	"Andy Shevchenko" <andy@infradead.org>,
	"Darren Hart" <dvhart@infradead.org>,
	"Jaroslav Kysela" <perex@perex.cz>,
	"Kailang Yang" <kailang@realtek.com>,
	<linux-kernel@vger.kernel.org>,
	<platform-driver-x86@vger.kernel.org>
Subject: Re: [PATCH v1 2/2] sound: Enable micmute led for Huawei laptops
Date: Wed, 15 May 2019 15:11:42 +0200	[thread overview]
Message-ID: <s5hk1erj20h.wl-tiwai@suse.de> (raw)
In-Reply-To: <20190513203009.28686-3-ayman.bagabas@gmail.com>

On Mon, 13 May 2019 22:30:06 +0200,
Ayman Bagabas wrote:
> 
> Since this LED is found on huawei laptops, we can hook it to
> huawei-wmi platform driver which uses the common WMI interface present
> in these laptops to control the LED.
> 
> I've also made some renames and used product name instead of common name
> to avoid confusion.
> 
> Signed-off-by: Ayman Bagabas <ayman.bagabas@gmail.com>

This looks applicable independently from the patch 1?
If so, it can go via sound git tree while another via x86-platform
tree.

thanks,

Takashi

> ---
>  sound/pci/hda/patch_realtek.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 42cd3945e0de..3661470766ba 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -5684,7 +5684,7 @@ enum {
>  	ALC298_FIXUP_TPT470_DOCK,
>  	ALC255_FIXUP_DUMMY_LINEOUT_VERB,
>  	ALC255_FIXUP_DELL_HEADSET_MIC,
> -	ALC256_FIXUP_HUAWEI_MBXP_PINS,
> +	ALC256_FIXUP_HUAWEI_MACH_WX9_PINS,
>  	ALC295_FIXUP_HP_X360,
>  	ALC221_FIXUP_HP_HEADSET_MIC,
>  	ALC285_FIXUP_LENOVO_HEADPHONE_NOISE,
> @@ -5975,7 +5975,7 @@ static const struct hda_fixup alc269_fixups[] = {
>  		.chained = true,
>  		.chain_id = ALC269_FIXUP_HEADSET_MIC
>  	},
> -	[ALC256_FIXUP_HUAWEI_MBXP_PINS] = {
> +	[ALC256_FIXUP_HUAWEI_MACH_WX9_PINS] = {
>  		.type = HDA_FIXUP_PINS,
>  		.v.pins = (const struct hda_pintbl[]) {
>  			{0x12, 0x90a60130},
> @@ -6996,9 +6996,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x17aa, 0x511f, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
>  	SND_PCI_QUIRK(0x17aa, 0x3bf8, "Quanta FL1", ALC269_FIXUP_PCM_44K),
>  	SND_PCI_QUIRK(0x17aa, 0x9e54, "LENOVO NB", ALC269_FIXUP_LENOVO_EAPD),
> -	SND_PCI_QUIRK(0x19e5, 0x3200, "Huawei MBX", ALC255_FIXUP_MIC_MUTE_LED),
> -	SND_PCI_QUIRK(0x19e5, 0x3201, "Huawei MBX", ALC255_FIXUP_MIC_MUTE_LED),
> -	SND_PCI_QUIRK(0x19e5, 0x3204, "Huawei MBXP", ALC256_FIXUP_HUAWEI_MBXP_PINS),
> +	SND_PCI_QUIRK(0x19e5, 0x3204, "Huawei MACH-WX9", ALC256_FIXUP_HUAWEI_MACH_WX9_PINS),
>  	SND_PCI_QUIRK(0x1b7d, 0xa831, "Ordissimo EVE2 ", ALC269VB_FIXUP_ORDISSIMO_EVE2), /* Also known as Malata PC-B1303 */
>  
>  #if 0
> @@ -7057,6 +7055,7 @@ static const struct snd_pci_quirk alc269_fixup_vendor_tbl[] = {
>  	SND_PCI_QUIRK_VENDOR(0x103c, "HP", ALC269_FIXUP_HP_MUTE_LED),
>  	SND_PCI_QUIRK_VENDOR(0x104d, "Sony VAIO", ALC269_FIXUP_SONY_VAIO),
>  	SND_PCI_QUIRK_VENDOR(0x17aa, "Thinkpad", ALC269_FIXUP_THINKPAD_ACPI),
> +	SND_PCI_QUIRK_VENDOR(0x19e5, "Huawei Matebook", ALC255_FIXUP_MIC_MUTE_LED),
>  	{}
>  };
>  
> -- 
> 2.20.1
> 
> 