From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754167AbdK1Tnt (ORCPT <rfc822;w@1wt.eu>);
        Tue, 28 Nov 2017 14:43:49 -0500
Received: from mx2.suse.de ([195.135.220.15]:56571 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754102AbdK1Tns (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 28 Nov 2017 14:43:48 -0500
Date: Tue, 28 Nov 2017 20:43:45 +0100
Message-ID: <s5hk1yajij2.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: alsa-devel@alsa-project.org, Arvind Yadav <arvind.yadav.cs@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Sakamoto <o-takashi@sakamocchi.jp>,
        kernel-janitors@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: ALSA: nm256: Fine-tuning for three function implementations
In-Reply-To: <19724fa4-47eb-827c-cb17-126440500179@users.sourceforge.net>
References: <d98a2685-ddf9-1cba-839a-d12c5ff8d3ba@users.sourceforge.net>
        <c2b7543c-cd2c-f7f6-98f3-23e2ca6f8b90@users.sourceforge.net>
        <s5hshcyr2on.wl-tiwai@suse.de>
        <539adde3-a713-721f-2a0d-1d1ef925fb86@users.sourceforge.net>
        <s5hpo82r1s5.wl-tiwai@suse.de>
        <9a9348f4-d059-de28-1445-0189b7fb0ba3@users.sourceforge.net>
        <s5hlgiqr0ad.wl-tiwai@suse.de>
        <3b7b24bd-4bdf-752e-1a62-cc71e9152acc@users.sourceforge.net>
        <s5hbmjmqxzs.wl-tiwai@suse.de>
        <bafa4437-2aaf-245d-da60-2353ca5debab@users.sourceforge.net>
        <s5h8teqqxhx.wl-tiwai@suse.de>
        <f7189a7c-3b07-e976-ac18-6143365bbd21@users.sourceforge.net>
        <s5h7euaqwtp.wl-tiwai@suse.de>
        <a1cd0902-c8bb-9813-8d0c-d394975ef745@users.sourceforge.net>
        <s5h4lpeqvin.wl-tiwai@suse.de>
        <6da7e6dc-b181-d26c-9f09-6592469193be@users.sourceforge.net>
        <s5hvahupdwe.wl-tiwai@suse.de>
        <fda75395-50ac-cd81-b483-6f03833472fb@users.sourceforge.net>
        <s5hr2sipd2z.wl-tiwai@suse.de>
        <99282c06-bfad-d7cf-16d8-eb1e015ebdbd@users.sourceforge.net>
        <s5hr2sijlp7.wl-tiwai@suse.de>
        <19724fa4-47eb-827c-cb17-126440500179@users.sourceforge.net>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 28 Nov 2017 20:08:13 +0100,
SF Markus Elfring wrote:
> 
> >> Examples:
> >> * ALSA: cs5530: Use common error handling code in snd_cs5530_probe()
> >>   https://lkml.org/lkml/2017/11/18/266
> >>   https://patchwork.kernel.org/patch/10064945/
> >>   https://lkml.kernel.org/r/<a2cb6494-a01c-668a-cd9b-1a8428a0d4c9@users.sourceforge.net>
> > 
> > This is no trivial patch.
> 
> Why do you find this one more challenging now than a similar one?
> 
> ALSA: maestro3: Use common error handling code in two functions
> https://lkml.org/lkml/2017/9/6/39
> https://patchwork.kernel.org/patch/9939985/
> https://lkml.kernel.org/r/<83b1ba49-253d-72ed-b3b0-ec7d5e72a12c@users.sourceforge.net>

Because it turned out that your patch can be wrong and broken.


Takashi