From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1759075AbYERQ3D@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1759075AbYERQ3D (ORCPT <rfc822;w@1wt.eu>);
	Sun, 18 May 2008 12:29:03 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753061AbYERQ2w
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Sun, 18 May 2008 12:28:52 -0400
Received: from cantor2.suse.de ([195.135.220.15]:34227 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752411AbYERQ2w (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sun, 18 May 2008 12:28:52 -0400
Date: Sun, 18 May 2008 18:28:50 +0200
Message-ID: <s5hk5hrd1a5.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Stas Sergeev <stsp@aknet.ru>
Cc: Roberto Oppedisano <roberto.oppedisano@infracom.it>,
       LKML <linux-kernel@vger.kernel.org>, alsa-devel@alsa-project.org
Subject: Re: [patch] snd-pcsp: silent misleading warning
In-Reply-To: <48306837.7030505@aknet.ru>
References: <482737BE.20502@infracom.it>
	<4827415A.7060101@aknet.ru>
	<482756F0.8020609@infracom.it>
	<48275D8D.10500@aknet.ru>
	<4827F0A1.9090600@infracom.it>
	<48288ACC.1020909@aknet.ru>
	<48299F08.2060702@infracom.it>
	<4829B6A1.90707@infracom.it>
	<s5h7idycfmf.wl%tiwai@suse.de>
	<482A7A17.8070706@infracom.it>
	<s5hwslxb3t8.wl%tiwai@suse.de>
	<482C9A3E.3000009@infracom.it>
	<482C9F3E.4050104@aknet.ru>
	<482EC93E.7080702@infracom.it>
	<482EFED2.1020504@aknet.ru>
	<s5hskwgkqe1.wl%tiwai@suse.de>
	<48306837.7030505@aknet.ru>
User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.7
 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta28) (fuki)
 (+CVS-20070806) (i386-suse-linux)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

At Sun, 18 May 2008 21:32:39 +0400,
Stas Sergeev wrote:
> 
> Hello.
> 
> Takashi Iwai wrote:
> >>> [  417.338143] PCSP: playback_ptr inconsistent (4642 4661 18645)
> >> It turns out that the buffer size you
> >> get, is not evenly devided by period size.
> >> 18645 % 4661 = 1.
> >> That (wrongly) triggers the warning.
> >> This may very well be an alsa bug, or
> >> may not, but the code in the driver is
> >> handling that properly, so there is no
> >> need for such a verbose warning.
> > The right fix would be to add a hw_constraint to align the buffer
> > size.  The simplest way is to add the following in PCM open callback.
> But what does this fix? That's only a
> warning, the driver itself doesn't care
> at all. The fix you propose, will need
> more testing, at least a confirmation
> from the reporter. I simply thought this
> can't happen. Now you say its a perfectly
> sane situation, and then there is nothing
> to care about, just shut up the warning.
> No?

Well, judging from your previous comment, I thought that it's no sane
situation for *your* driver.  But if the driver doesn't care in
practice, your fix should be fine.  I'll queue it on my tree. 

thanks,

Takashi