From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A351C433F5 for ; Tue, 26 Oct 2021 06:02:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E5AC760E96 for ; Tue, 26 Oct 2021 06:02:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234900AbhJZGE7 (ORCPT ); Tue, 26 Oct 2021 02:04:59 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:33272 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229940AbhJZGEz (ORCPT ); Tue, 26 Oct 2021 02:04:55 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 8DD131F770; Tue, 26 Oct 2021 06:02:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1635228151; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gKjUTHtHr46Zc0mVSdHDGYdXrEbguNkHOoWnUzmutUs=; b=D/qXAf7Eu7sWFSHvK/0ZeELZ9ibSQjoAvrPrPCvw1OElb2vV7eDe8N7JdwYNuFM3ic4Rpn jp3IpEKI8oGQ/FpK5nnlmblAmOx11LzdEKFtZcmUrrisqwWH9z29AR++vn2uXAjrIWRauB BTBMDYcp6BQu6QD17Jf+tQQmLLaEdKk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1635228151; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gKjUTHtHr46Zc0mVSdHDGYdXrEbguNkHOoWnUzmutUs=; b=/KBXeWoQOOaLAVKwtgDpxwJ0dxhCEvShId6hoqwNn546nxPwB6IoEcunZMfrv1VIS3FScP aFyeHF57wZz3TtDA== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 7AD14A3B85; Tue, 26 Oct 2021 06:02:29 +0000 (UTC) Date: Tue, 26 Oct 2021 08:02:29 +0200 Message-ID: From: Takashi Iwai To: Chengfeng Ye Cc: perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sound/isa/gus: fix null pointer dereference on pointer block In-Reply-To: <20211024104611.9919-1-cyeaa@connect.ust.hk> References: <20211024104611.9919-1-cyeaa@connect.ust.hk> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 24 Oct 2021 12:46:11 +0200, Chengfeng Ye wrote: > > The pointer block return from snd_gf1_dma_next_block could be > null, so there is a potential null pointer dereference issue. > Fix this by adding a null check before dereference. > > Signed-off-by: Chengfeng Ye Thanks, applied. Takashi