* [PATCH] ALSA: hda/realtek - Enable the headset mic on Asus FX505DT
@ 2020-04-10 9:00 Adam Barber
2020-04-11 6:51 ` Takashi Iwai
0 siblings, 1 reply; 4+ messages in thread
From: Adam Barber @ 2020-04-10 9:00 UTC (permalink / raw)
To: tiwai; +Cc: alsa-devel, linux-kernel, Adam Barber
On Asus FX505DT with Realtek ALC233, the headset mic is connected
to pin 0x19, with default 0x411111f0.
Enable headset mic by reconfiguring the pin to an external mic
associated with the headphone on 0x21. Mic jack detection was also
found to be working.
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=207131
Signed-off-by: Adam Barber <barberadam995@gmail.com>
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index f66a48154a57..5016fa50956a 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -7252,6 +7252,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x1043, 0x16e3, "ASUS UX50", ALC269_FIXUP_STEREO_DMIC),
SND_PCI_QUIRK(0x1043, 0x17d1, "ASUS UX431FL", ALC294_FIXUP_ASUS_DUAL_SPK),
SND_PCI_QUIRK(0x1043, 0x18b1, "Asus MJ401TA", ALC256_FIXUP_ASUS_HEADSET_MIC),
+ SND_PCI_QUIRK(0x1043, 0x18f1, "Asus FX505DT", ALC256_FIXUP_ASUS_HEADSET_MIC),
SND_PCI_QUIRK(0x1043, 0x19ce, "ASUS B9450FA", ALC294_FIXUP_ASUS_HPE),
SND_PCI_QUIRK(0x1043, 0x1a13, "Asus G73Jw", ALC269_FIXUP_ASUS_G73JW),
SND_PCI_QUIRK(0x1043, 0x1a30, "ASUS X705UD", ALC256_FIXUP_ASUS_MIC),
--
2.26.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ALSA: hda/realtek - Enable the headset mic on Asus FX505DT
2020-04-10 9:00 [PATCH] ALSA: hda/realtek - Enable the headset mic on Asus FX505DT Adam Barber
@ 2020-04-11 6:51 ` Takashi Iwai
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2020-04-11 6:51 UTC (permalink / raw)
To: Adam Barber; +Cc: tiwai, alsa-devel, linux-kernel
On Fri, 10 Apr 2020 11:00:32 +0200,
Adam Barber wrote:
>
> On Asus FX505DT with Realtek ALC233, the headset mic is connected
> to pin 0x19, with default 0x411111f0.
>
> Enable headset mic by reconfiguring the pin to an external mic
> associated with the headphone on 0x21. Mic jack detection was also
> found to be working.
>
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=207131
> Signed-off-by: Adam Barber <barberadam995@gmail.com>
Thanks, applied now with Cc to stable.
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ALSA: hda/realtek - Enable the headset mic on Asus FX505DT
2020-04-10 0:55 Adam Barber
@ 2020-04-10 8:14 ` Takashi Iwai
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2020-04-10 8:14 UTC (permalink / raw)
To: Adam Barber; +Cc: tiwai, alsa-devel, linux-kernel
On Fri, 10 Apr 2020 02:55:33 +0200,
Adam Barber wrote:
>
> On Asus FX505DT with Realtek ALC233, the headset mic is connected
> to pin 0x19, with default 0x411111f0.
>
> Enable headset mic by reconfiguring the pin to an external mic
> associated with the headphone on 0x21. Mic jack detection was also
> found to be working.
Could you give your sign-off? It's mandatory for merging to upstream.
Also, if there is some information linke (e.g. Bugzilla), put it in
"BugLink: $URL" line, too.
thanks,
Takashi
> ---
> sound/pci/hda/patch_realtek.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index f66a48154a57..5016fa50956a 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -7252,6 +7252,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> SND_PCI_QUIRK(0x1043, 0x16e3, "ASUS UX50", ALC269_FIXUP_STEREO_DMIC),
> SND_PCI_QUIRK(0x1043, 0x17d1, "ASUS UX431FL", ALC294_FIXUP_ASUS_DUAL_SPK),
> SND_PCI_QUIRK(0x1043, 0x18b1, "Asus MJ401TA", ALC256_FIXUP_ASUS_HEADSET_MIC),
> + SND_PCI_QUIRK(0x1043, 0x18f1, "Asus FX505DT", ALC256_FIXUP_ASUS_HEADSET_MIC),
> SND_PCI_QUIRK(0x1043, 0x19ce, "ASUS B9450FA", ALC294_FIXUP_ASUS_HPE),
> SND_PCI_QUIRK(0x1043, 0x1a13, "Asus G73Jw", ALC269_FIXUP_ASUS_G73JW),
> SND_PCI_QUIRK(0x1043, 0x1a30, "ASUS X705UD", ALC256_FIXUP_ASUS_MIC),
> --
> 2.26.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ALSA: hda/realtek - Enable the headset mic on Asus FX505DT
@ 2020-04-10 0:55 Adam Barber
2020-04-10 8:14 ` Takashi Iwai
0 siblings, 1 reply; 4+ messages in thread
From: Adam Barber @ 2020-04-10 0:55 UTC (permalink / raw)
To: tiwai; +Cc: alsa-devel, linux-kernel, Adam Barber
On Asus FX505DT with Realtek ALC233, the headset mic is connected
to pin 0x19, with default 0x411111f0.
Enable headset mic by reconfiguring the pin to an external mic
associated with the headphone on 0x21. Mic jack detection was also
found to be working.
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index f66a48154a57..5016fa50956a 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -7252,6 +7252,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x1043, 0x16e3, "ASUS UX50", ALC269_FIXUP_STEREO_DMIC),
SND_PCI_QUIRK(0x1043, 0x17d1, "ASUS UX431FL", ALC294_FIXUP_ASUS_DUAL_SPK),
SND_PCI_QUIRK(0x1043, 0x18b1, "Asus MJ401TA", ALC256_FIXUP_ASUS_HEADSET_MIC),
+ SND_PCI_QUIRK(0x1043, 0x18f1, "Asus FX505DT", ALC256_FIXUP_ASUS_HEADSET_MIC),
SND_PCI_QUIRK(0x1043, 0x19ce, "ASUS B9450FA", ALC294_FIXUP_ASUS_HPE),
SND_PCI_QUIRK(0x1043, 0x1a13, "Asus G73Jw", ALC269_FIXUP_ASUS_G73JW),
SND_PCI_QUIRK(0x1043, 0x1a30, "ASUS X705UD", ALC256_FIXUP_ASUS_MIC),
--
2.26.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-04-11 6:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-10 9:00 [PATCH] ALSA: hda/realtek - Enable the headset mic on Asus FX505DT Adam Barber
2020-04-11 6:51 ` Takashi Iwai
-- strict thread matches above, loose matches on Subject: below --
2020-04-10 0:55 Adam Barber
2020-04-10 8:14 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).