From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0156EC43441 for ; Wed, 21 Nov 2018 16:51:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C4BB3214DB for ; Wed, 21 Nov 2018 16:51:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C4BB3214DB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732010AbeKVD0p (ORCPT ); Wed, 21 Nov 2018 22:26:45 -0500 Received: from mx2.suse.de ([195.135.220.15]:41424 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726172AbeKVD0o (ORCPT ); Wed, 21 Nov 2018 22:26:44 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 3B3AFAE10; Wed, 21 Nov 2018 16:51:31 +0000 (UTC) Date: Wed, 21 Nov 2018 17:51:30 +0100 Message-ID: From: Takashi Iwai To: "Girija Kumar Kasinadhuni" Cc: , "Hui Wang" , "Jaroslav Kysela" , "KailangYang" , Subject: Re: [PATCH] ALSA: hda/realtek - Add disable auto-mute quirk for HP Spectre x360 laptop In-Reply-To: <1542809492-54931-1-git-send-email-gkumar@neverware.com> References: <1542809492-54931-1-git-send-email-gkumar@neverware.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/26 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 21 Nov 2018 15:11:31 +0100, Girija Kumar Kasinadhuni wrote: > > This device makes a loud buzzing sound when a headphone is inserted while > playing audio at full volume through the speaker. > > Signed-off-by: Girija Kumar Kasinadhuni The fixup entry you added won't "disable" but it switch to the auto-mute via amp instead of toggling pin control. Please correct the subject and the description, and resubmit. thanks, Takashi > --- > sound/pci/hda/patch_realtek.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index fa61674..eeff2ff 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -5495,6 +5495,7 @@ enum { > ALC255_FIXUP_DELL_HEADSET_MIC, > ALC295_FIXUP_HP_X360, > ALC221_FIXUP_HP_HEADSET_MIC, > + ALC295_FIXUP_HP_DISABLE_AUTOMUTE, > }; > > static const struct hda_fixup alc269_fixups[] = { > @@ -6362,6 +6363,10 @@ static const struct hda_fixup alc269_fixups[] = { > .chained = true, > .chain_id = ALC269_FIXUP_HEADSET_MIC > }, > + [ALC295_FIXUP_HP_DISABLE_AUTOMUTE] = { > + .type = HDA_FIXUP_FUNC, > + .v.func = alc_fixup_auto_mute_via_amp, > + }, > }; > > static const struct snd_pci_quirk alc269_fixup_tbl[] = { > @@ -6486,6 +6491,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x103c, 0x82bf, "HP", ALC221_FIXUP_HP_MIC_NO_PRESENCE), > SND_PCI_QUIRK(0x103c, 0x82c0, "HP", ALC221_FIXUP_HP_MIC_NO_PRESENCE), > SND_PCI_QUIRK(0x103c, 0x83b9, "HP Spectre x360", ALC269_FIXUP_HP_MUTE_LED_MIC3), > + SND_PCI_QUIRK(0x103c, 0x83b9, "HP Spectre X360 ", ALC295_FIXUP_HP_DISABLE_AUTOMUTE), > SND_PCI_QUIRK(0x1043, 0x103e, "ASUS X540SA", ALC256_FIXUP_ASUS_MIC), > SND_PCI_QUIRK(0x1043, 0x103f, "ASUS TX300", ALC282_FIXUP_ASUS_TX300), > SND_PCI_QUIRK(0x1043, 0x106d, "Asus K53BE", ALC269_FIXUP_LIMIT_INT_MIC_BOOST), > -- > 2.7.4 >