From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760930AbbA2CEJ (ORCPT ); Wed, 28 Jan 2015 21:04:09 -0500 Received: from cantor2.suse.de ([195.135.220.15]:45565 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754343AbbA2CEC (ORCPT ); Wed, 28 Jan 2015 21:04:02 -0500 Date: Wed, 28 Jan 2015 22:27:25 +0100 Message-ID: From: Takashi Iwai To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] drivers/base/node: Use device_create_files() and device_remove_files() In-Reply-To: <20150128210623.GB18649@kroah.com> References: <1422477974-8369-1-git-send-email-tiwai@suse.de> <1422477974-8369-3-git-send-email-tiwai@suse.de> <20150128210623.GB18649@kroah.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.4 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Wed, 28 Jan 2015 13:06:23 -0800, Greg Kroah-Hartman wrote: > > On Wed, Jan 28, 2015 at 09:46:14PM +0100, Takashi Iwai wrote: > > Use the new helper functions to simplify the code. > > > > Signed-off-by: Takashi Iwai > > --- > > drivers/base/node.c | 24 ++++++++++++------------ > > 1 file changed, 12 insertions(+), 12 deletions(-) > > > > diff --git a/drivers/base/node.c b/drivers/base/node.c > > index a3b82e9c7f20..e567e7bde333 100644 > > --- a/drivers/base/node.c > > +++ b/drivers/base/node.c > > @@ -200,6 +200,16 @@ static ssize_t node_read_distance(struct device *dev, > > } > > static DEVICE_ATTR(distance, S_IRUGO, node_read_distance, NULL); > > > > +static const struct device_attribute *node_dev_attrs[] = { > > + &dev_attr_cpumap, > > + &dev_attr_cpulist, > > + &dev_attr_meminfo, > > + &dev_attr_numastat, > > + &dev_attr_distance, > > + &dev_attr_vmstat, > > + NULL > > +}; > > + > > #ifdef CONFIG_HUGETLBFS > > /* > > * hugetlbfs per node attributes registration interface: > > @@ -276,12 +286,7 @@ static int register_node(struct node *node, int num, struct node *parent) > > error = device_register(&node->dev); > > > > if (!error){ > > - device_create_file(&node->dev, &dev_attr_cpumap); > > - device_create_file(&node->dev, &dev_attr_cpulist); > > - device_create_file(&node->dev, &dev_attr_meminfo); > > - device_create_file(&node->dev, &dev_attr_numastat); > > - device_create_file(&node->dev, &dev_attr_distance); > > - device_create_file(&node->dev, &dev_attr_vmstat); > > + device_create_files(&node->dev, node_dev_attrs); > > This should just be using an attribute group instead of these files all > being created at once, care to switch the code to use that instead? OK, this would be relatively easily converted to attribute group. Let me check later... Takashi