From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757078AbbA1UYK (ORCPT ); Wed, 28 Jan 2015 15:24:10 -0500 Received: from cantor2.suse.de ([195.135.220.15]:58648 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757033AbbA1UYI (ORCPT ); Wed, 28 Jan 2015 15:24:08 -0500 Date: Wed, 28 Jan 2015 15:56:39 +0100 Message-ID: From: Takashi Iwai To: Arnd Bergmann Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] sound: sscape: add missing include of asm/io.h In-Reply-To: <7794866.XZSLAdxcrb@wuerfel> References: <7794866.XZSLAdxcrb@wuerfel> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.4 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Wed, 28 Jan 2015 15:54:04 +0100, Arnd Bergmann wrote: > > The soundscape driver uses the ISA inb/outb functions declared > in asm/io.h, so it needs to include this header to avoid > a build error: > > sscape.c: In function 'sscape_write_unsafe': > sscape.c:203:2: error: implicit declaration of function 'outb' [-Werror=implicit-function-declaration] > > Signed-off-by: Arnd Bergmann Could you correct asm/io.h with linux/io.h in subject and description to match with the actual change? thanks, Takashi > > diff --git a/sound/isa/sscape.c b/sound/isa/sscape.c > index 018ab140c2be..7b248cdf06e2 100644 > --- a/sound/isa/sscape.c > +++ b/sound/isa/sscape.c > @@ -23,6 +23,7 @@ > > #include > #include > +#include > #include > #include > #include >