From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752306AbaKQMqM (ORCPT ); Mon, 17 Nov 2014 07:46:12 -0500 Received: from cantor2.suse.de ([195.135.220.15]:54587 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751138AbaKQMqK (ORCPT ); Mon, 17 Nov 2014 07:46:10 -0500 Date: Mon, 17 Nov 2014 13:46:08 +0100 Message-ID: From: Takashi Iwai To: SF Markus Elfring Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, LKML , kernel-janitors@vger.kernel.org, Coccinelle Subject: Re: [PATCH 1/1] ALSA: ice17xx: Deletion of unnecessary checks before the function call "snd_ac97_resume" In-Reply-To: <5469CF2E.6040408@users.sourceforge.net> References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <5469CF2E.6040408@users.sourceforge.net> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.4 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Mon, 17 Nov 2014 11:34:22 +0100, SF Markus Elfring wrote: > > From: Markus Elfring > Date: Mon, 17 Nov 2014 11:28:02 +0100 > > The snd_ac97_resume() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Applied, thanks. Takashi > --- > sound/pci/ice1712/ice1712.c | 3 +-- > sound/pci/ice1712/ice1724.c | 3 +-- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/sound/pci/ice1712/ice1712.c b/sound/pci/ice1712/ice1712.c > index 87f7fc4..e1e18b5 100644 > --- a/sound/pci/ice1712/ice1712.c > +++ b/sound/pci/ice1712/ice1712.c > @@ -2905,8 +2905,7 @@ static int snd_ice1712_resume(struct device *dev) > outw(ice->pm_saved_spdif_ctrl, ICEMT(ice, ROUTE_SPDOUT)); > outw(ice->pm_saved_route, ICEMT(ice, ROUTE_PSDOUT03)); > > - if (ice->ac97) > - snd_ac97_resume(ice->ac97); > + snd_ac97_resume(ice->ac97); > > snd_power_change_state(card, SNDRV_CTL_POWER_D0); > return 0; > diff --git a/sound/pci/ice1712/ice1724.c b/sound/pci/ice1712/ice1724.c > index 08cb08a..0e56835 100644 > --- a/sound/pci/ice1712/ice1724.c > +++ b/sound/pci/ice1712/ice1724.c > @@ -2884,8 +2884,7 @@ static int snd_vt1724_resume(struct device *dev) > outb(ice->pm_saved_spdif_cfg, ICEREG1724(ice, SPDIF_CFG)); > outl(ice->pm_saved_route, ICEMT1724(ice, ROUTE_PLAYBACK)); > > - if (ice->ac97) > - snd_ac97_resume(ice->ac97); > + snd_ac97_resume(ice->ac97); > > snd_power_change_state(card, SNDRV_CTL_POWER_D0); > return 0; > -- > 2.1.3 > >