From: Takashi Iwai <tiwai@suse.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Ruslan Bilovol <ruslan.bilovol@gmail.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] ALSA: usb: initial USB Audio Device Class 3.0 support
Date: Thu, 09 Nov 2017 09:16:52 +0100 [thread overview]
Message-ID: <s5hmv3vvpcb.wl-tiwai@suse.de> (raw)
In-Reply-To: <20171109080458.GC17098@kroah.com>
On Thu, 09 Nov 2017 09:04:58 +0100,
Greg Kroah-Hartman wrote:
>
> On Wed, Nov 08, 2017 at 03:38:35PM +0100, Takashi Iwai wrote:
> > On Tue, 07 Nov 2017 03:01:20 +0100,
> > Ruslan Bilovol wrote:
> > >
> > > Recently released USB Audio Class 3.0 specification
> > > introduces many significant changes comparing to
> > > previous versions, like
> > > - new Power Domains, support for LPM/L1
> > > - new Cluster descriptor
> > > - changed layout of all class-specific descriptors
> > > - new High Capability descriptors
> > > - New class-specific String descriptors
> > > - new and removed units
> > > - additional sources for interrupts
> > > - removed Type II Audio Data Formats
> > > - ... and many other things (check spec)
> > >
> > > It also provides backward compatibility through
> > > multiple configurations, as well as requires
> > > mandatory support for BADD (Basic Audio Device
> > > Definition) on each ADC3.0 compliant device
> > >
> > > This patch adds initial support of UAC3 specification
> > > that is enough for Generic I/O Profile (BAOF, BAIF)
> > > device support from BADD document.
> > >
> > > Signed-off-by: Ruslan Bilovol <ruslan.bilovol@gmail.com>
> >
> > The patch looks good, but the timing is fairly late for merging to
> > 4.15.
>
> Isn't kbuild barfing all over these? Is that because of the cross-tree
> changes needed?
No, it's just local to the audio driver, plus a few
include/linux/usb/*.h modification / addition.
So there shouldn't be a big breakage in that regard.
> > So from my side, the primary question is whether the changes in USB
> > (audio) header files are OK for USB guys.
> >
> > Greg, could you check these changes and give an ack if it's OK to
> > merge? Or if you prefer postpone, just let me know.
>
> I don't object to the USB header changes, as long as the fixes you point
> out are made :)
Good to hear.
Could you give your acked-by once after reviewing the patch?
I think this should go through sound tree.
Thanks!
Takashi
next prev parent reply other threads:[~2017-11-09 8:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 2:01 [PATCH 0/1] USB Audio Device Class 3.0 support Ruslan Bilovol
2017-11-07 2:01 ` [PATCH 1/1] ALSA: usb: initial " Ruslan Bilovol
2017-11-08 14:38 ` Takashi Iwai
2017-11-09 8:04 ` Greg Kroah-Hartman
2017-11-09 8:16 ` Takashi Iwai [this message]
2017-11-09 8:33 ` Greg Kroah-Hartman
2017-11-09 8:58 ` Takashi Iwai
2017-11-11 2:56 ` Ruslan Bilovol
2017-11-11 7:29 ` Takashi Iwai
2017-11-10 11:12 ` Ruslan Bilovol
2017-11-08 16:46 ` kbuild test robot
2017-11-08 19:38 ` [alsa-devel] " Pierre-Louis Bossart
2017-11-11 2:48 ` Ruslan Bilovol
2017-11-13 16:07 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hmv3vvpcb.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ruslan.bilovol@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).