From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760894AbbA2CEH (ORCPT ); Wed, 28 Jan 2015 21:04:07 -0500 Received: from cantor2.suse.de ([195.135.220.15]:45566 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753446AbbA2CEC (ORCPT ); Wed, 28 Jan 2015 21:04:02 -0500 Date: Wed, 28 Jan 2015 22:26:28 +0100 Message-ID: From: Takashi Iwai To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] Add device_create_files() and device_remove_files() helpers In-Reply-To: <20150128210547.GA18649@kroah.com> References: <1422477974-8369-1-git-send-email-tiwai@suse.de> <20150128210547.GA18649@kroah.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.4 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Wed, 28 Jan 2015 13:05:47 -0800, Greg Kroah-Hartman wrote: > > On Wed, Jan 28, 2015 at 09:46:12PM +0100, Takashi Iwai wrote: > > Hi, > > > > this is a simple patch to add device_create_files() and > > device_remove_files() to replace multiple device_create_file() or > > _remove() calls with a single shot with the device_attr list. > > > > It's basically just a clean up, but also helps to simplify the error > > handling a lot in many existing codes since the function itself does > > rollback at error. > > > > The series contains a patch to apply these to drivers/base/node.c. > > I have lots of patches (up to 30) to use these in the whole tree, but > > maybe it'd be easier too apply once after this stuff is merged at > > first. It's just a cleanup so no urgent task, after all. > > I'd like to some day be able to drop device_create_file entirely, as it > is almost always used in a racy way (but not always, so we can't get rid > of it today.) > > A driver should be using an attribute group and be created/registered > with it if they want any files associated with it, so giving people the > ability to add large numbers of files all at once seems like the wrong > thing to do :) Well, through the glance over many codes using device_create_file(), I think the problem of the attribute group is that there is little help for generating the entries dynamically. For example, if you have two groups you want to enable conditionally, what would be the best way to implement? I don't mean that my device_create_files() is best, but to me it looks like that proper tools are still missing. thanks, Takashi