From: Takashi Iwai <tiwai@suse.de>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Oliver Neukum <oneukum@suse.de>, Michal Marek <mmarek@suse.cz>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pciehp: Add pciehp_surprise module option
Date: Wed, 20 Mar 2013 20:23:39 +0100 [thread overview]
Message-ID: <s5hmwtxq3ic.wl%tiwai@suse.de> (raw)
In-Reply-To: <20130320191250.GA11262@srcf.ucam.org>
At Wed, 20 Mar 2013 19:12:50 +0000,
Matthew Garrett wrote:
>
> On Wed, Mar 20, 2013 at 08:11:15PM +0100, Takashi Iwai wrote:
> > At Wed, 20 Mar 2013 17:52:34 +0000,
> > Matthew Garrett wrote:
> > > Well that just sounds like a bug. What's the downside to just ignoring
> > > that capability bit?
> >
> > I'm afraid that it's too radical to enable always.
>
> Why?
Because I'm conservative :)
Well, dunno. It's just my feeling without deep thought.
> > Or, what about to check this bit only for disable path?
>
> What happens if you unplug the device on one of the affected machines?
It continues working. I mean, the PCI device is still there after
unplug, but the Realtek driver unmounts it smoothly. Re-plugging also
works, too. So, the handling via pciehp is needed only for the very
first time to register the PCI device.
Takashi
next prev parent reply other threads:[~2013-03-20 19:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 14:02 [PATCH] pciehp: Add pciehp_surprise module option Takashi Iwai
2013-03-20 16:33 ` Randy Dunlap
2013-03-20 16:39 ` Takashi Iwai
2013-03-20 17:52 ` Matthew Garrett
2013-03-20 19:11 ` Takashi Iwai
2013-03-20 19:12 ` Matthew Garrett
2013-03-20 19:23 ` Takashi Iwai [this message]
2013-03-20 19:26 ` Matthew Garrett
2013-03-20 18:09 ` Alex Williamson
2013-03-20 19:08 ` Takashi Iwai
2013-03-22 16:15 ` Michal Marek
2013-03-22 16:16 ` Matthew Garrett
2013-03-22 16:35 ` Michal Marek
2013-03-22 16:20 ` Alex Williamson
2013-03-27 16:11 ` Oliver Neukum
2013-03-27 16:19 ` Michal Marek
2013-03-20 18:41 ` Martin Mokrejs
2013-03-20 18:56 ` Martin Mokrejs
2013-03-20 19:20 ` Takashi Iwai
2013-06-07 0:04 ` Martin Mokrejs
2013-03-25 16:58 ` Bjorn Helgaas
2013-04-10 16:34 ` Takashi Iwai
2013-04-10 17:19 ` Bjorn Helgaas
2013-04-11 13:40 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hmwtxq3ic.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=mmarek@suse.cz \
--cc=oneukum@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).