From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751926Ab2LEHqN (ORCPT ); Wed, 5 Dec 2012 02:46:13 -0500 Received: from cantor2.suse.de ([195.135.220.15]:55511 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751408Ab2LEHqL (ORCPT ); Wed, 5 Dec 2012 02:46:11 -0500 Date: Wed, 05 Dec 2012 08:46:10 +0100 Message-ID: From: Takashi Iwai To: David Howells Cc: Michal Marek , linux-kernel@vger.kernel.org, rusty@ozlabs.org, Takashi Iwai Subject: Re: [PATCH 2/3] MODSIGN: Avoid using .incbin in C source In-Reply-To: <22396.1354645048@warthog.procyon.org.uk> References: <1354616321-13520-2-git-send-email-mmarek@suse.cz> <1354616321-13520-1-git-send-email-mmarek@suse.cz> <22396.1354645048@warthog.procyon.org.uk> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Tue, 04 Dec 2012 18:17:28 +0000, David Howells wrote: > > Michal Marek wrote: > > > Using the asm .incbin statement in C sources breaks any gcc wrapper which > > assumes that preprocessed C source is self-contained. Use a separate .S > > file to include the siging key and certificate. > > I was trying to avoid that as .S files generally don't crop up in generic > code and the format of the assembly varies with the arch. However, you don't > seem to have anything that should cause a problem Well, we hit actually the issue... Please check the revised patch again. thanks, Takashi > - so: > > Acked-by: David Howells >