From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD5DDC433FE for ; Thu, 9 Sep 2021 11:55:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9589861CF1 for ; Thu, 9 Sep 2021 11:55:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242247AbhIIL4v (ORCPT ); Thu, 9 Sep 2021 07:56:51 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:33768 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241491AbhIILyQ (ORCPT ); Thu, 9 Sep 2021 07:54:16 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 9F62622376; Thu, 9 Sep 2021 11:53:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1631188382; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UCQLO2IbVqctc2BGQv11qcnpDIpuIqJg85PCOnX6wUg=; b=oxJTIny45fDt3iBjfRCgl/yDttmXQULX4CmEFzHFZDkWaVOYbPZLoOzGmeuxYY/gIgY6EA n5zzahWr8yq3JehltwZ14q4yneL8MERcUjVvZRIrxM8rQS9L09hc+nzEnDbZ67v4j1h8vE Qt3ExHsY3REBRJcZEsrmRAjj5VsuPbI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1631188382; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UCQLO2IbVqctc2BGQv11qcnpDIpuIqJg85PCOnX6wUg=; b=AQX0+8SSlp6R1LGwRxmoHhe4BAuo/8QXlfDBI5m7ELZULKzE7wKCswr9FjixHxIPCEizz2 CzWfjuZ1yE3t9tCw== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 96142A3D1F; Thu, 9 Sep 2021 11:53:02 +0000 (UTC) Date: Thu, 09 Sep 2021 13:53:02 +0200 Message-ID: From: Takashi Iwai To: Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH AUTOSEL 5.14 132/252] ALSA: pci: cs46xx: Fix set up buffer type properly In-Reply-To: <20210909114106.141462-132-sashal@kernel.org> References: <20210909114106.141462-1-sashal@kernel.org> <20210909114106.141462-132-sashal@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 09 Sep 2021 13:39:06 +0200, Sasha Levin wrote: > > From: Takashi Iwai > > [ Upstream commit 4d9e9153f1c64d91a125c6967bc0bfb0bb653ea0 ] > > CS46xx driver switches the buffer depending on the number of periods, > and in some cases it switches to the own buffer without updating the > buffer type properly. This may cause a problem with the mmap on > exotic architectures that require the own mmap call for the coherent > DMA buffer. > > This patch addresses the potential breakage by replacing the buffer > setup with the proper macro. It also simplifies the source code, > too. > > Link: https://lore.kernel.org/r/20210809071829.22238-4-tiwai@suse.de > Signed-off-by: Takashi Iwai > Signed-off-by: Sasha Levin This change is superfluous for 5.14. Please drop. thanks, Takashi