linux-next: build failure after merge of the sound-current tree

linux-next: build failure after merge of the sound-current tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 570 bytes --]

Hi all,

After merging the sound-current tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

/home/sfr/next/next/sound/usb/card.c: In function 'snd_usb_autoresume':
/home/sfr/next/next/sound/usb/card.c:841:29: error: expected ';' before ')' token
  841 |    atomic_dec(&chip->active))
      |                             ^
      |                             ;

Caused by commit

  3398e5c7b038 ("ALSA: usb-audio: Manage auto-pm of all bundled interfaces")

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the sound-current tree

[Macpaul Lin]

On Fri, 2020-06-05 at 08:43 +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the sound-current tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> /home/sfr/next/next/sound/usb/card.c: In function 'snd_usb_autoresume':
> /home/sfr/next/next/sound/usb/card.c:841:29: error: expected ';' before ')' token
>   841 |    atomic_dec(&chip->active))
>       |                             ^
>       |                             ;
> 
> Caused by commit
> 
>   3398e5c7b038 ("ALSA: usb-audio: Manage auto-pm of all bundled interfaces")
> 
> I have reverted that commit for today.
> 

Sorry I've tested its function by "patch back" to older kernel version
4.14.
After checking the latest patch again, there is indeed a typo here.

Thanks
Macpaul Lin

Re: linux-next: build failure after merge of the sound-current tree

[Takashi Iwai]

On Fri, 05 Jun 2020 04:18:29 +0200,
Macpaul Lin wrote:
> 
> On Fri, 2020-06-05 at 08:43 +1000, Stephen Rothwell wrote:
> > Hi all,
> > 
> > After merging the sound-current tree, today's linux-next build (arm
> > multi_v7_defconfig) failed like this:
> > 
> > /home/sfr/next/next/sound/usb/card.c: In function 'snd_usb_autoresume':
> > /home/sfr/next/next/sound/usb/card.c:841:29: error: expected ';' before ')' token
> >   841 |    atomic_dec(&chip->active))
> >       |                             ^
> >       |                             ;
> > 
> > Caused by commit
> > 
> >   3398e5c7b038 ("ALSA: usb-audio: Manage auto-pm of all bundled interfaces")
> > 
> > I have reverted that commit for today.
> > 
> 
> Sorry I've tested its function by "patch back" to older kernel version
> 4.14.
> After checking the latest patch again, there is indeed a typo here.

Sorry for the mess, somehow a wrong version was pushed and merged.
I also tested but overlooked it...

Will scratch and resubmit the corrected one.


Takashi

Re: linux-next: build failure after merge of the sound-current tree

[Takashi Iwai]

On Tue, 12 Mar 2024 22:51:36 +0100,
Stephen Rothwell wrote:
> 
> Hi all,
> 
> After merging the sound-current tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> sound/usb/stream.c: In function 'convert_chmap':
> sound/usb/stream.c:306:34: error: 'chmaps' undeclared (first use in this function); did you mean 'chmap'?
>   306 |                         if (c == chmaps->channels)
>       |                                  ^~~~~~
>       |                                  chmap
> sound/usb/stream.c:306:34: note: each undeclared identifier is reported only once for each function it appears in
> 
> Caused by commit
> 
>   a94566ace3ca ("ALSA: usb-audio: Stop parsing channels bits when all channels are found.")
> 
> I have reverted that commit for today.

My bad, I dropped the bad patch.  Sorry for inconvenience.


Takashi

linux-next: build failure after merge of the sound-current tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 741 bytes --]

Hi all,

After merging the sound-current tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

sound/usb/stream.c: In function 'convert_chmap':
sound/usb/stream.c:306:34: error: 'chmaps' undeclared (first use in this function); did you mean 'chmap'?
  306 |                         if (c == chmaps->channels)
      |                                  ^~~~~~
      |                                  chmap
sound/usb/stream.c:306:34: note: each undeclared identifier is reported only once for each function it appears in

Caused by commit

  a94566ace3ca ("ALSA: usb-audio: Stop parsing channels bits when all channels are found.")

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the sound-current tree

[Takashi Iwai]

On Wed, 10 Nov 2021 00:00:03 +0100,
Stephen Rothwell wrote:
> 
> Hi all,
> 
> After merging the sound-current tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> sound/core/memalloc.c:720:32: error: 'snd_dma_sg_wc_ops' undeclared here (not in a function); did you mean 'snd_dma_sg_ops'?
>   720 |  [SNDRV_DMA_TYPE_DEV_WC_SG] = &snd_dma_sg_wc_ops,
>       |                                ^~~~~~~~~~~~~~~~~
>       |                                snd_dma_sg_ops
> sound/core/memalloc.c:651:12: error: 'snd_dma_sg_wc_mmap' defined but not used [-Werror=unused-function]
>   651 | static int snd_dma_sg_wc_mmap(struct snd_dma_buffer *dmab,
>       |            ^~~~~~~~~~~~~~~~~~
> sound/core/memalloc.c:641:13: error: 'snd_dma_sg_wc_free' defined but not used [-Werror=unused-function]
>   641 | static void snd_dma_sg_wc_free(struct snd_dma_buffer *dmab)
>       |             ^~~~~~~~~~~~~~~~~~
> sound/core/memalloc.c:628:14: error: 'snd_dma_sg_wc_alloc' defined but not used [-Werror=unused-function]
>   628 | static void *snd_dma_sg_wc_alloc(struct snd_dma_buffer *dmab, size_t size)
>       |              ^~~~~~~~~~~~~~~~~~~
> 
> Caused by commit
> 
>   d51f779940fb ("ALSA: memalloc: Unify x86 SG-buffer handling (take#2)")
> 
> I have used the sound-current tree from next-20211109 for today.

Sorry for the mess, I dropped the problematic patch.  Somehow a wrong
version was submitted and merged.


Takashi

linux-next: build failure after merge of the sound-current tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1275 bytes --]

Hi all,

After merging the sound-current tree, today's linux-next build (x86_64
allmodconfig) failed like this:

sound/core/memalloc.c:720:32: error: 'snd_dma_sg_wc_ops' undeclared here (not in a function); did you mean 'snd_dma_sg_ops'?
  720 |  [SNDRV_DMA_TYPE_DEV_WC_SG] = &snd_dma_sg_wc_ops,
      |                                ^~~~~~~~~~~~~~~~~
      |                                snd_dma_sg_ops
sound/core/memalloc.c:651:12: error: 'snd_dma_sg_wc_mmap' defined but not used [-Werror=unused-function]
  651 | static int snd_dma_sg_wc_mmap(struct snd_dma_buffer *dmab,
      |            ^~~~~~~~~~~~~~~~~~
sound/core/memalloc.c:641:13: error: 'snd_dma_sg_wc_free' defined but not used [-Werror=unused-function]
  641 | static void snd_dma_sg_wc_free(struct snd_dma_buffer *dmab)
      |             ^~~~~~~~~~~~~~~~~~
sound/core/memalloc.c:628:14: error: 'snd_dma_sg_wc_alloc' defined but not used [-Werror=unused-function]
  628 | static void *snd_dma_sg_wc_alloc(struct snd_dma_buffer *dmab, size_t size)
      |              ^~~~~~~~~~~~~~~~~~~

Caused by commit

  d51f779940fb ("ALSA: memalloc: Unify x86 SG-buffer handling (take#2)")

I have used the sound-current tree from next-20211109 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]