linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Navid Emamdoost <emamd001@umn.edu>,
	alsa-devel@alsa-project.org,
	Navid Emamdoost <navid.emamdoost@gmail.com>,
	Kangjie Lu <kjlu@umn.edu>, Stephen McCamant <smccaman@umn.edu>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Richard Fontana <rfontana@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	kernel-janitors@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	linux-doc@vger.kernel.org
Subject: Re: [alsa-devel] ALSA: korg1212: Checking exception handling in snd_korg1212_create()
Date: Mon, 28 Oct 2019 14:15:42 +0100	[thread overview]
Message-ID: <s5ho8y1au4h.wl-tiwai@suse.de> (raw)
In-Reply-To: <ec3647df-0e54-4aaa-7ec7-b3dec0fa1965@web.de>

On Mon, 28 Oct 2019 10:00:21 +0100,
Markus Elfring wrote:
> 
> > The code path is after snd_device_new() which has its own destructor callback.
> 
> Thanks for your reminder.
> 
> Can the properties of this programming interface be documented also together
> with the function declaration for the safer handling of ALSA components?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/sound/kernel-api/writing-an-alsa-driver.rst?id=d6d5df1db6e9d7f8f76d2911707f7d5877251b02#n567

I can think of only adding some comment at each point mentioning that
the resource will be managed by the device destructor.

> Can any more API information help to improve automatic source code analysis
> around similar functions?

If anything we can add, let me know.


Takashi

  reply	other threads:[~2019-10-28 13:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-27 19:12 [PATCH] ALSA: pci: Fix memory leak in snd_korg1212_create Navid Emamdoost
2019-10-27 20:40 ` Markus Elfring
2019-10-28  8:19   ` Markus Elfring
2019-10-28  6:31 ` [PATCH] " Takashi Iwai
2019-10-28  9:00   ` [alsa-devel] ALSA: korg1212: Checking exception handling in snd_korg1212_create() Markus Elfring
2019-10-28 13:15     ` Takashi Iwai [this message]
2019-10-28 14:40       ` Markus Elfring
2019-10-28 14:44         ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5ho8y1au4h.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=Markus.Elfring@web.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=emamd001@umn.edu \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kjlu@umn.edu \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=navid.emamdoost@gmail.com \
    --cc=rfontana@redhat.com \
    --cc=smccaman@umn.edu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).