From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030634AbXCLQiy (ORCPT ); Mon, 12 Mar 2007 12:38:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030636AbXCLQix (ORCPT ); Mon, 12 Mar 2007 12:38:53 -0400 Received: from mail.suse.de ([195.135.220.2]:53071 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030634AbXCLQiw (ORCPT ); Mon, 12 Mar 2007 12:38:52 -0400 Date: Mon, 12 Mar 2007 17:38:51 +0100 Message-ID: From: Takashi Iwai To: Ralf Baechle Cc: Andrew Morton , perex@suse.cz, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [SOUND] hda_intel: build fix In-Reply-To: <20070312154647.GC11974@linux-mips.org> References: <20070310190513.GA24435@linux-mips.org> <20070312135351.GA11974@linux-mips.org> <20070312154647.GC11974@linux-mips.org> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta27) (fiddleheads) (+CVS-20060704) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=ISO-8859-7 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org At Mon, 12 Mar 2007 15:46:47 +0000, Ralf Baechle wrote: > > On Mon, Mar 12, 2007 at 03:43:10PM +0100, Takashi Iwai wrote: > > > Fair enough. I agree that removing const is the only reasonable fix > > right now. But from semantics, const is a good thing, and people may > > try to add it again later if we get rid of them now. So, how about to > > comment out such as /*const*/ in each place to remind that it's > > intentional? > > I consider that harder to read and uglier. If anything maybe something > like: > > #define __const_devinit > [...] > static __const_devinit struct snd_kcontrol_new snd_ice1712_delta1010lt_wordclock_status __devinitdata = > > Worth it? I doubt. Well that's really a taste of matter... > > Also, in your patch to ice1712, you don't have to remove const from the > > codes in snd_ice1712_read_eeprom() and snd_ice1712_probe() functions. > > They should work as const pointer. > > No, that results in warnings: > > CC sound/pci/ice1712/ice1712.o > sound/pci/ice1712/ice1712.c: In function Ħsnd_ice1712_read_eeprom˘: > sound/pci/ice1712/ice1712.c:2354: warning: assignment from incompatible pointer type > sound/pci/ice1712/ice1712.c: In function Ħsnd_ice1712_probe˘: > sound/pci/ice1712/ice1712.c:2693: warning: assignment from incompatible pointer type Ah, that's a nasty part of C const. It should be like const struct snd_ice1712_card_info *c; but for pointer-of-pointer, something like struct snd_ice1712_card_info * const *tbl; ...? Takashi