From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FC1CC433E0 for ; Fri, 26 Mar 2021 08:01:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2A12461A05 for ; Fri, 26 Mar 2021 08:01:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230012AbhCZIBP (ORCPT ); Fri, 26 Mar 2021 04:01:15 -0400 Received: from mx2.suse.de ([195.135.220.15]:39128 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229551AbhCZIAi (ORCPT ); Fri, 26 Mar 2021 04:00:38 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 4B95CAE03; Fri, 26 Mar 2021 08:00:37 +0000 (UTC) Date: Fri, 26 Mar 2021 09:00:37 +0100 Message-ID: From: Takashi Iwai To: Muhammad Usama Anjum Cc: Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, colin.king@canonical.com, dan.carpenter@oracle.com Subject: Re: [PATCH] ALSA: usb-audio: Don't store returned value and check for errors In-Reply-To: <20210325083641.GA644957@LEGION> References: <20210325083641.GA644957@LEGION> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 25 Mar 2021 09:36:41 +0100, Muhammad Usama Anjum wrote: > > The returned value by create_autodetect_quirk isn't being used other > than in the success check on next line. Remove the return value > assignement. Check for error values instead of success check. > > Signed-off-by: Muhammad Usama Anjum > --- > sound/usb/quirks.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c > index 9e5e37eff10e..5ce5f4ecb9d0 100644 > --- a/sound/usb/quirks.c > +++ b/sound/usb/quirks.c > @@ -425,9 +425,9 @@ static int create_autodetect_quirks(struct snd_usb_audio *chip, > USB_CLASS_VENDOR_SPEC) > continue; > > - err = create_autodetect_quirk(chip, iface, driver); > - if (err >= 0) > - usb_driver_claim_interface(driver, iface, (void *)-1L); > + if (create_autodetect_quirk(chip, iface, driver) < 0) > + continue; > + usb_driver_claim_interface(driver, iface, (void *)-1L); Hm, basically this change is only for readability (the code optimization makes almost no sense), and the readability itself isn't improved significantly by this change, either. That is, I'm fine to take this, but OTOH, I see no compelling reason to do so... thanks, Takashi