From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44ADDC0650E for ; Wed, 3 Jul 2019 09:35:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2430921882 for ; Wed, 3 Jul 2019 09:35:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726628AbfGCJfw (ORCPT ); Wed, 3 Jul 2019 05:35:52 -0400 Received: from mx2.suse.de ([195.135.220.15]:35644 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725847AbfGCJfw (ORCPT ); Wed, 3 Jul 2019 05:35:52 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id E39A9AF46; Wed, 3 Jul 2019 09:35:50 +0000 (UTC) Date: Wed, 03 Jul 2019 11:35:50 +0200 Message-ID: From: Takashi Iwai To: Greg Kroah-Hartman Cc: "Rafael J. Wysocki" , Mark Brown , Linux Kernel Mailing List Subject: Re: [PATCH 2/2] debugfs: log errors when something goes wrong In-Reply-To: <20190703093233.GA4436@kroah.com> References: <20190703071653.2799-1-gregkh@linuxfoundation.org> <20190703071653.2799-2-gregkh@linuxfoundation.org> <20190703093233.GA4436@kroah.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 03 Jul 2019 11:32:33 +0200, Greg Kroah-Hartman wrote: > > On Wed, Jul 03, 2019 at 11:10:44AM +0200, Rafael J. Wysocki wrote: > > On Wed, Jul 3, 2019 at 9:17 AM Greg Kroah-Hartman > > wrote: > > > > > > As it is not recommended that debugfs calls be checked, it was pointed > > > out that major errors should still be logged somewhere so that > > > developers and users have a chance to figure out what went wrong. To > > > help with this, error logging has been added to the debugfs core so that > > > it is not needed to be present in every individual file that calls > > > debugfs. > > > > > > Reported-by: Mark Brown > > > Reported-by: Takashi Iwai > > > Cc: "Rafael J. Wysocki" > > > Signed-off-by: Greg Kroah-Hartman > > > > Generally speaking > > > > Reviewed-by: Rafael J. Wysocki > > > > > --- > > > fs/debugfs/inode.c | 25 ++++++++++++++++++++----- > > > 1 file changed, 20 insertions(+), 5 deletions(-) > > > > > > diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c > > > index f04c8475d9a1..7f43c8acfcbf 100644 > > > --- a/fs/debugfs/inode.c > > > +++ b/fs/debugfs/inode.c > > > @@ -2,8 +2,9 @@ > > > /* > > > * inode.c - part of debugfs, a tiny little debug file system > > > * > > > - * Copyright (C) 2004 Greg Kroah-Hartman > > > + * Copyright (C) 2004,2019 Greg Kroah-Hartman > > > * Copyright (C) 2004 IBM Inc. > > > + * Copyright (C) 2019 Linux Foundation > > > * > > > * debugfs is for people to use instead of /proc or /sys. > > > * See ./Documentation/core-api/kernel-api.rst for more details. > > > @@ -294,8 +295,10 @@ static struct dentry *start_creating(const char *name, struct dentry *parent) > > > > > > error = simple_pin_fs(&debug_fs_type, &debugfs_mount, > > > &debugfs_mount_count); > > > - if (error) > > > + if (error) { > > > + pr_err("Unable to pin filesystem for file '%s'\n", name); > > > > But I'm not sure about the log level here. Particularly, why would > > pr_info() not work? > > It could, but it is an error in that debugfs didn't do what was asked of > it. I really don't care either way, the odds of anyone ever seeing this > message is almost none :) Yes, that's an obvious error and I see no big reason to hide it. For both: Reviewed-by: Takashi Iwai Thanks! Takashi