* [PATCH] ALSA: usb-audio: fix CM6206 register definitions
@ 2019-01-08 20:03 Amadeusz Sławiński
2019-01-08 21:52 ` Takashi Iwai
2019-01-11 14:14 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Amadeusz Sławiński @ 2019-01-08 20:03 UTC (permalink / raw)
To: linux-kernel, alsa-devel, Linus Walleij, Takashi Iwai
Cc: Amadeusz Sławiński
fix typo after a recent commit causing headphones to have no sound
Fixes: ad43d528a7ac (ALSA: usb-audio: Define registers for CM6206)
Signed-off-by: Amadeusz Sławiński <amade@asmblr.net>
---
sound/usb/quirks.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
index 96340f23f86d..ebbadb3a7094 100644
--- a/sound/usb/quirks.c
+++ b/sound/usb/quirks.c
@@ -768,7 +768,7 @@ static int snd_usb_cm6206_boot_quirk(struct usb_device *dev)
* REG1: PLL binary search enable, soft mute enable.
*/
CM6206_REG1_PLLBIN_EN |
- CM6206_REG1_SOFT_MUTE_EN |
+ CM6206_REG1_SOFT_MUTE_EN,
/*
* REG2: enable output drivers,
* select front channels to the headphone output,
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ALSA: usb-audio: fix CM6206 register definitions
2019-01-08 20:03 [PATCH] ALSA: usb-audio: fix CM6206 register definitions Amadeusz Sławiński
@ 2019-01-08 21:52 ` Takashi Iwai
2019-01-11 14:14 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2019-01-08 21:52 UTC (permalink / raw)
To: Amadeusz Sławiński; +Cc: alsa-devel, Linus Walleij, linux-kernel
On Tue, 08 Jan 2019 21:03:11 +0100,
Amadeusz Sławiński wrote:
>
> fix typo after a recent commit causing headphones to have no sound
>
> Fixes: ad43d528a7ac (ALSA: usb-audio: Define registers for CM6206)
> Signed-off-by: Amadeusz Sławiński <amade@asmblr.net>
> ---
> sound/usb/quirks.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
> index 96340f23f86d..ebbadb3a7094 100644
> --- a/sound/usb/quirks.c
> +++ b/sound/usb/quirks.c
> @@ -768,7 +768,7 @@ static int snd_usb_cm6206_boot_quirk(struct usb_device *dev)
> * REG1: PLL binary search enable, soft mute enable.
> */
> CM6206_REG1_PLLBIN_EN |
> - CM6206_REG1_SOFT_MUTE_EN |
> + CM6206_REG1_SOFT_MUTE_EN,
> /*
> * REG2: enable output drivers,
> * select front channels to the headphone output,
Argh, that's a nasty error, thanks for spotting out.
Applied now.
Takashi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ALSA: usb-audio: fix CM6206 register definitions
2019-01-08 20:03 [PATCH] ALSA: usb-audio: fix CM6206 register definitions Amadeusz Sławiński
2019-01-08 21:52 ` Takashi Iwai
@ 2019-01-11 14:14 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2019-01-11 14:14 UTC (permalink / raw)
To: Amadeusz Sławiński
Cc: linux-kernel,
moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...,
Takashi Iwai
On Tue, Jan 8, 2019 at 9:02 PM Amadeusz Sławiński <amade@asmblr.net> wrote:
> fix typo after a recent commit causing headphones to have no sound
>
> Fixes: ad43d528a7ac (ALSA: usb-audio: Define registers for CM6206)
> Signed-off-by: Amadeusz Sławiński <amade@asmblr.net>
Ooops sorry for this! Thanks for fixing it!
BTW FYI what I am trying to do is get the code in workable order
to get the S/PDIF in working. Right now output works, and I am
going to test whether it works under windows.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-11 15:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-08 20:03 [PATCH] ALSA: usb-audio: fix CM6206 register definitions Amadeusz Sławiński
2019-01-08 21:52 ` Takashi Iwai
2019-01-11 14:14 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).