From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751732AbbESRJQ (ORCPT <rfc822;w@1wt.eu>);
	Tue, 19 May 2015 13:09:16 -0400
Received: from cantor2.suse.de ([195.135.220.15]:37097 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750960AbbESRJN (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 19 May 2015 13:09:13 -0400
Date: Tue, 19 May 2015 19:09:12 +0200
Message-ID: <s5hr3qctryf.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Jonathan McDowell <noodles@earth.li>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: Audio crackles with 4.1-rc1
In-Reply-To: <20150519161911.GD28070@earth.li>
References: <s5hvbggv4xa.wl-tiwai@suse.de>
	<20150428123518.GU10148@earth.li>
	<s5hpp6ov1wv.wl-tiwai@suse.de>
	<s5ha8xsuxe3.wl-tiwai@suse.de>
	<20150429112859.GY10148@earth.li>
	<s5h4mnzgne6.wl-tiwai@suse.de>
	<20150430150131.GA10148@earth.li>
	<s5hd22l7dgo.wl-tiwai@suse.de>
	<20150502150513.GF10148@earth.li>
	<s5hk2w514aj.wl-tiwai@suse.de>
	<20150519161911.GD28070@earth.li>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

At Tue, 19 May 2015 17:19:11 +0100,
Jonathan McDowell wrote:
> 
> On Tue, May 19, 2015 at 08:15:32AM +0200, Takashi Iwai wrote:
> > At Sat, 2 May 2015 16:05:13 +0100,
> > Jonathan McDowell wrote:
> > > 
> > > On Thu, Apr 30, 2015 at 07:06:31PM +0200, Takashi Iwai wrote:
> > > > At Thu, 30 Apr 2015 16:01:31 +0100, Jonathan McDowell wrote:
> > > > > 
> > > > > On Wed, Apr 29, 2015 at 01:54:57PM +0200, Takashi Iwai wrote:
> > > > > > 
> > > > > > One patch you can try (with or without power_save_node
> > > > > > disablement) is below, it squashes the verb sequences at (runtime)
> > > > > > PM resume as we did for 4.0.  Let me know if this changes the
> > > > > > behavior.
> > > > > 
> > > > > Patch alone has no effect. Patch with power_save_node disablement
> > > > > solves the problem. Didn't try power_save_node disablement without
> > > > > the patch.
> > > > 
> > > > Then please confirm that only power_save_node disablement suffices.
> > > > This can be considered as the least change that can be put to 4.1-rc
> > > > if no better fix is found.
> > > 
> > > Setting codec->power_save_node to 0 in patch_alc269 is sufficient; no
> > > noticeable cracking occurring.
> > 
> > Does the patch below have any improvement?
> 
> I still get a clicking on the standby -> active transition with the
> patch provided on top of 4.1-rc4.

OK, just to be sure, could you check whether changing msleep(10) to
msleep(100) makes no difference?  Also put a line like
	pr_info("XXX power up %x\n", nid);
after msleep() call to see which nodes are powered up dynamically.


Takashi