From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751884AbaLCG74 (ORCPT ); Wed, 3 Dec 2014 01:59:56 -0500 Received: from cantor2.suse.de ([195.135.220.15]:49824 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751819AbaLCG7z (ORCPT ); Wed, 3 Dec 2014 01:59:55 -0500 Date: Wed, 03 Dec 2014 07:59:53 +0100 Message-ID: From: Takashi Iwai To: SF Markus Elfring Cc: Jaroslav Kysela , Johannes Berg , alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH] ALSA: i2sbus: Deletion of unnecessary checks before the function call "release_and_free_resource" In-Reply-To: <547E356D.9050609@users.sourceforge.net> References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <547E356D.9050609@users.sourceforge.net> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.4 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Tue, 02 Dec 2014 22:55:57 +0100, SF Markus Elfring wrote: > > From: Markus Elfring > Date: Tue, 2 Dec 2014 22:50:24 +0100 > > The release_and_free_resource() function tests whether its argument is NULL > and then returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Thanks, applied. Takashi > --- > sound/aoa/soundbus/i2sbus/core.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/sound/aoa/soundbus/i2sbus/core.c b/sound/aoa/soundbus/i2sbus/core.c > index a80d5ea..4e2b4fb 100644 > --- a/sound/aoa/soundbus/i2sbus/core.c > +++ b/sound/aoa/soundbus/i2sbus/core.c > @@ -79,8 +79,7 @@ static void i2sbus_release_dev(struct device *dev) > if (i2sdev->out.dbdma) iounmap(i2sdev->out.dbdma); > if (i2sdev->in.dbdma) iounmap(i2sdev->in.dbdma); > for (i = aoa_resource_i2smmio; i <= aoa_resource_rxdbdma; i++) > - if (i2sdev->allocated_resource[i]) > - release_and_free_resource(i2sdev->allocated_resource[i]); > + release_and_free_resource(i2sdev->allocated_resource[i]); > free_dbdma_descriptor_ring(i2sdev, &i2sdev->out.dbdma_ring); > free_dbdma_descriptor_ring(i2sdev, &i2sdev->in.dbdma_ring); > for (i = aoa_resource_i2smmio; i <= aoa_resource_rxdbdma; i++) > @@ -323,8 +322,7 @@ static int i2sbus_add_dev(struct macio_dev *macio, > if (dev->out.dbdma) iounmap(dev->out.dbdma); > if (dev->in.dbdma) iounmap(dev->in.dbdma); > for (i=0;i<3;i++) > - if (dev->allocated_resource[i]) > - release_and_free_resource(dev->allocated_resource[i]); > + release_and_free_resource(dev->allocated_resource[i]); > mutex_destroy(&dev->lock); > kfree(dev); > return 0; > -- > 2.1.3 >