From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B21E8C48BDF for ; Sun, 20 Jun 2021 06:53:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 84F6B60FDB for ; Sun, 20 Jun 2021 06:53:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229541AbhFTGyg (ORCPT ); Sun, 20 Jun 2021 02:54:36 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:42932 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229471AbhFTGyf (ORCPT ); Sun, 20 Jun 2021 02:54:35 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id C5EC421AD2; Sun, 20 Jun 2021 06:52:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1624171942; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GVd/eu3+mlAoMFZ7WdRdOKoYQfcAe3ALecq+sJg7xaI=; b=VuSDRJB+11fUtiABRX5fS11vowNvu1BP3RKhf0vPbz9wGYapzXb3PKL/6ac4tmmrjDl9zt G6Vc/BFjde1kg6xLkLdTQzNxL8sG04qp643bnMdzQnXVj/SiqRZU49BiQMNc82tYMzB6En k0X+wQJsqQWlwIGQaXEIkO23mmKMNY8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1624171942; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GVd/eu3+mlAoMFZ7WdRdOKoYQfcAe3ALecq+sJg7xaI=; b=gm3AMJ894Mjdzi2E3+D7bQVQO6N1CasxD+c9+qo3dnZbk7lsAjVdjqvxYoRTzSA62dbwxn 0SNjH5/2tZZ8OmCw== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 3DD0FA3B81; Sun, 20 Jun 2021 06:52:22 +0000 (UTC) Date: Sun, 20 Jun 2021 08:52:22 +0200 Message-ID: From: Takashi Iwai To: Elia Devito Cc: Jaroslav Kysela , Takashi Iwai , Kailang Yang , Jeremy Szu , Hui Wang , Jian-Hong Pan , Chris Chiu , Huacai Chen , Sami Loone , Werner Sembach , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: hda/realtek: Improve fixup for HP Spectre x360 15-df0xxx In-Reply-To: <20210619204105.5682-1-eliadevito@gmail.com> References: <20210619204105.5682-1-eliadevito@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 19 Jun 2021 22:41:04 +0200, Elia Devito wrote: > > On HP Spectre x360 15-df0xxx, after system boot with plugged headset, the > headset mic are not detected. > Moving pincfg and DAC's config to single fixup function fix this. > > Signed-off-by: Elia Devito Oh, this was an unintended bug. The actual fix isn't about moving two things into one fixup, but rather dropping the superfluous chain to ALC269_FIXUP_THINKPAD_ACPI. Now applied with some more comments (and Cc to stable). Thanks. Takashi