From: Takashi Iwai <tiwai@suse.de>
To: Vitaly Rodionov <vitalyr@opensource.cirrus.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
<alsa-devel@alsa-project.org>, <patches@opensource.cirrus.com>,
<linux-kernel@vger.kernel.org>,
Stefan Binding <sbinding@opensource.cirrus.com>
Subject: Re: [PATCH v1 4/4] ALSA: hda/cirrus: Make CS8409 driver more generic by using fixups.
Date: Mon, 15 Mar 2021 08:49:56 +0100 [thread overview]
Message-ID: <s5hsg4wrh3v.wl-tiwai@suse.de> (raw)
In-Reply-To: <20210313113410.90088-5-vitalyr@opensource.cirrus.com>
On Sat, 13 Mar 2021 12:34:10 +0100,
Vitaly Rodionov wrote:
> @@ -1357,6 +1362,22 @@ static const struct hda_verb cs8409_cs42l42_init_verbs[] = {
> { 0x47, AC_VERB_SET_PROC_COEF, 0x0080 }, /* I2C mode */
> { 0x47, AC_VERB_SET_COEF_INDEX, 0x005b }, /* Set I2C bus speed */
> { 0x47, AC_VERB_SET_PROC_COEF, 0x0200 }, /* 100kHz I2C_STO = 2 */
> + { 0x24, AC_VERB_SET_CONFIG_DEFAULT_BYTES_0, 0xF0 }, /* Widget node ASP-1-TX */
> + { 0x24, AC_VERB_SET_CONFIG_DEFAULT_BYTES_1, 0x20 },
> + { 0x24, AC_VERB_SET_CONFIG_DEFAULT_BYTES_2, 0x21 },
> + { 0x24, AC_VERB_SET_CONFIG_DEFAULT_BYTES_3, 0x04 },
> + { 0x34, AC_VERB_SET_CONFIG_DEFAULT_BYTES_0, 0x50 }, /* Widget node ASP-1-RX0 */
> + { 0x34, AC_VERB_SET_CONFIG_DEFAULT_BYTES_1, 0x20 },
> + { 0x34, AC_VERB_SET_CONFIG_DEFAULT_BYTES_2, 0xa1 },
> + { 0x34, AC_VERB_SET_CONFIG_DEFAULT_BYTES_3, 0x04 },
> + { 0x2C, AC_VERB_SET_CONFIG_DEFAULT_BYTES_0, 0xF0 }, /* Widget node ASP-2-TX */
> + { 0x2C, AC_VERB_SET_CONFIG_DEFAULT_BYTES_1, 0x00 },
> + { 0x2C, AC_VERB_SET_CONFIG_DEFAULT_BYTES_2, 0x10 },
> + { 0x2C, AC_VERB_SET_CONFIG_DEFAULT_BYTES_3, 0x90 },
> + { 0x44, AC_VERB_SET_CONFIG_DEFAULT_BYTES_0, 0x90 }, /* Widget node DMIC-1 */
> + { 0x44, AC_VERB_SET_CONFIG_DEFAULT_BYTES_1, 0x00 },
> + { 0x44, AC_VERB_SET_CONFIG_DEFAULT_BYTES_2, 0xA0 },
> + { 0x44, AC_VERB_SET_CONFIG_DEFAULT_BYTES_3, 0x90 },
Those widgets are all pin widgets, right? If so, setting via the
pincfg table would be more suitable, as it's cached and exposed via
sysfs for debugging.
thanks,
Takashi
next prev parent reply other threads:[~2021-03-15 7:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-13 11:34 [PATCH v1 0/4] ALSA: hda/cirrus: Make CS8409 driver more generic by using fixups Vitaly Rodionov
2021-03-13 11:34 ` [PATCH v1 1/4] ALSA: hda/cirrus: Add error handling into CS8409 I2C functions Vitaly Rodionov
2021-03-15 7:45 ` Takashi Iwai
2021-03-15 15:37 ` Vitaly Rodionov
2021-03-15 15:41 ` Takashi Iwai
2021-03-13 11:34 ` [PATCH v1 2/4] ALSA: hda/cirrus: Cleanup patch_cirrus.c code Vitaly Rodionov
2021-03-13 11:34 ` [PATCH v1 3/4] ALSA: hda/cirrus: Fix CS42L42 Headset Mic volume control name Vitaly Rodionov
2021-03-13 11:34 ` [PATCH v1 4/4] ALSA: hda/cirrus: Make CS8409 driver more generic by using fixups Vitaly Rodionov
2021-03-15 7:49 ` Takashi Iwai [this message]
2021-03-15 15:39 ` Vitaly Rodionov
2021-03-14 8:36 ` [PATCH v1 0/4] " Takashi Iwai
2021-03-14 10:18 ` Vitaly Rodionov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hsg4wrh3v.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=sbinding@opensource.cirrus.com \
--cc=tiwai@suse.com \
--cc=vitalyr@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).