From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tiwai@suse.de>
X-Google-Smtp-Source: AIpwx49cBV8GxmcqRZ6eJrrp7MXj3gMpLqx4WtexoUQuqnK95dZIYh2JdaAL1d4MJMQyOeVFFoZ/
ARC-Seal: i=1; a=rsa-sha256; t=1524485472; cv=none;
        d=google.com; s=arc-20160816;
        b=tK8wl/z8opHv7L3RLhiSDOzWx8MpWGJLqgoTytIrEbjaL8EIdvy0Y9NJ+JrilhPhuC
         sfWaRLe9cuZrb6qpw1/nPF6qDy2v/x3dioUx/ZEHrtgFZ8ASwXN/1iJqnFx308nl+xYu
         34z0WcLUUnCvxBvkpZKH8Gv09f+D9xNsE81DTR3UeC0i2+ewe2LsdreF3V+R8iEiWnhN
         +0K4ijM9hkHWNaZuIF+AitcPPq+F4vjw9VYWdGI+xGusqYnaJrssuYzgEW03alPXOR1V
         sg8gBTRVrsMbsjnpXiMalaR2QilC2YlH+4K1x5IOZ1A1qX926Q6gWKUuARNmpgBHCmlk
         pEcw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=mime-version:user-agent:references:in-reply-to:subject:cc:to:from
         :message-id:date:arc-authentication-results;
        bh=bIJWWMUdYQ3wpBwFmrroZPE4H8fhXeVVy2TLn8vBgvk=;
        b=TwgueAvszwIWrG+1FiPVZTgUb9xHtFATU/XpV6jDyX3LvQc2Gy9JDaLBp4iSkwZq+G
         bNJIw7ru8PPlPzEwnWituCs9A29mklIrOnWztz2azBC65Xa9zGHUvvf36dGPMeIDRk1t
         LiebgJ4TE3eevc2jkfI2+wFRRfowFt8wbixPjH1HKG/rWjDssr6khGpXY53sSOl5faFy
         E4zXsC9iWWQX8UEiVuFqqwvwSQZtrXCwvU54b9sHjyrELPUVXe5DWTwSR+8Dko3Xx9Ed
         XIbfLaeCw7f02HaeeLApwvh8EV4R9CpUTNFNMa4kBkb4vYvUolMVE6/FQWv7UH5KON1G
         nBmA==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of tiwai@suse.de designates 195.135.220.15 as permitted sender) smtp.mailfrom=tiwai@suse.de
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of tiwai@suse.de designates 195.135.220.15 as permitted sender) smtp.mailfrom=tiwai@suse.de
Date: Mon, 23 Apr 2018 14:11:10 +0200
Message-ID: <s5hsh7mruld.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: "Jorge Sanjuan" <jorge.sanjuan@codethink.co.uk>
Cc: <alsa-devel@alsa-project.org>,
	"Michael Drake" <michael.drake@codethink.co.uk>,
	<gregkh@linuxfoundation.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] ALSA: usb-audio: ADC3: Fix channel mapping conversion for ADC3.
In-Reply-To: <20180420170327.31569-3-jorge.sanjuan@codethink.co.uk>
References: <20180420170327.31569-1-jorge.sanjuan@codethink.co.uk>
	<20180420170327.31569-3-jorge.sanjuan@codethink.co.uk>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: =?utf-8?q?1598285488536876967?=
X-GMAIL-MSGID: =?utf-8?q?1598538878342456666?=
X-Mailing-List: linux-kernel@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>

On Fri, 20 Apr 2018 19:03:25 +0200,
Jorge Sanjuan wrote:
> 
> From: Michael Drake <michael.drake@codethink.co.uk>
> 
> The channel mapping is defined by bChRelationship, not bChPurpose.
> 
> Signed-off-by: Michael Drake <michael.drake@codethink.co.uk>

The change looks OK, but your sign-off is missing.
If you submit a patch, please give always your signed-off-by tag, no
matter whether it's your original patch or not.

Also, the Fixes tag would be helpful for such a correction.


thanks,

Takashi