From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S935746AbXLQLGU@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S935746AbXLQLGU (ORCPT <rfc822;w@1wt.eu>);
	Mon, 17 Dec 2007 06:06:20 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S934854AbXLQLGJ
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Mon, 17 Dec 2007 06:06:09 -0500
Received: from ns2.suse.de ([195.135.220.15]:60176 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S935123AbXLQLGH (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 17 Dec 2007 06:06:07 -0500
Date: Mon, 17 Dec 2007 10:30:01 +0100
Message-ID: <s5hsl211xeu.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Marcin Slusarz <marcin.slusarz@gmail.com>
Cc: perex@perex.cz, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sound/core.h: include sound/driver.h
In-Reply-To: <20071216015825.GA26986@joi>
References: <20071208205040.GG5087@joi>
	<s5hwsrh5yjt.wl%tiwai@suse.de>
	<20071216015825.GA26986@joi>
User-Agent: Wanderlust/2.15.5 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta28)
 (fuki) (+CVS-20070806) (i386-suse-linux)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=ISO-8859-2
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

At Sun, 16 Dec 2007 02:58:31 +0100,
Marcin Slusarz wrote:
> 
> On Fri, Dec 14, 2007 at 12:02:46PM +0100, Takashi Iwai wrote:
> > At Sat, 8 Dec 2007 21:50:45 +0100,
> > Marcin Ślusarz wrote:
> > >
> > > sound/core.h: include sound/driver.h
> > >
> > > include sound/driver.h in sound/core.h because core.h
> > > uses SNDRV_CARDS (which is defined in sound/driver.h)
> > >
> > > Signed-off-by: Marcin Ślusarz <marcin.slusarz@gmail.com>
> >
> > Right now I have another (bigger) change for this include path, so
> > this patch won't be needed any more.
> >
> > I applied the patches to sound/* except for this one and
> > sound/memory.c.   Thanks!
> >
> Is there anything wrong with patch for rawmidi [1]?

Ah, sorry, forgot to mention it.

I'm still considering whether it's the best way.  The changes look
exaggerated just for fixing sparse warnings.


Takashi

> 
> Marcin
> 
> [1] http://lkml.org/lkml/2007/12/8/164
>