From: Takashi Iwai <tiwai@suse.de>
To: Henry Lin <henryl@nvidia.com>
Cc: Jaroslav Kysela <perex@perex.cz>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Allison Randal <allison@lohutok.net>,
"Thomas Gleixner" <tglx@linutronix.de>,
Richard Fontana <rfontana@redhat.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb-audio: not submit urb for stopped endpoint
Date: Tue, 12 Nov 2019 17:48:25 +0100 [thread overview]
Message-ID: <s5htv79niqu.wl-tiwai@suse.de> (raw)
In-Reply-To: <MN2PR12MB33899EA399AF4338AA882F1DAC770@MN2PR12MB3389.namprd12.prod.outlook.com>
On Tue, 12 Nov 2019 17:41:42 +0100,
Henry Lin wrote:
>
> > Ah, I see. Then you don't have to write up the full stack trace like
> > the above. It's confusing as if it were some kernel Oops or WARNING.
> Got it. Should I post another patch set here for removing these confusing description in commit message? Or you can help to remove them before merging?
Please resubmit after rephrasing the patch description.
> > BTW, with your patch, is the error in the first line ("timeout: still
> > 1 active urbs on EP #1") also fixed?
> Yes, "timeout: still 1 active urbs on EP #1" will be fixed as well.
OK, then this should be mentioned in the patch description.
Actually the patch fixes this kind of error (the stall at the
concurrent stream stop).
thanks,
Takashi
next prev parent reply other threads:[~2019-11-12 16:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 6:51 [PATCH] usb-audio: not submit urb for stopped endpoint Henry Lin
2019-11-12 7:31 ` Takashi Iwai
2019-11-12 16:13 ` Henry Lin
2019-11-12 16:25 ` Takashi Iwai
2019-11-12 16:41 ` Henry Lin
2019-11-12 16:48 ` Takashi Iwai [this message]
2019-11-13 2:14 ` [PATCH v2] " Henry Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5htv79niqu.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=allison@lohutok.net \
--cc=alsa-devel@alsa-project.org \
--cc=gregkh@linuxfoundation.org \
--cc=henryl@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=rfontana@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).