From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71E41C10F0E for ; Fri, 12 Apr 2019 14:21:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 45CAC20818 for ; Fri, 12 Apr 2019 14:21:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727127AbfDLOVD (ORCPT ); Fri, 12 Apr 2019 10:21:03 -0400 Received: from mx2.suse.de ([195.135.220.15]:55784 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726327AbfDLOVC (ORCPT ); Fri, 12 Apr 2019 10:21:02 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 81AB3AD7D; Fri, 12 Apr 2019 14:21:01 +0000 (UTC) Date: Fri, 12 Apr 2019 16:21:01 +0200 Message-ID: From: Takashi Iwai To: Mark Brown Cc: Pierre-Louis Bossart , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, vkoul@kernel.org, gregkh@linuxfoundation.org, liam.r.girdwood@linux.intel.com, jank@cadence.com, joe@perches.com, srinivas.kandagatla@linaro.org, "Rafael J. Wysocki" Subject: Re: [alsa-devel] [PATCH 1/2] regmap: soundwire: fix Kconfig select/depend issue In-Reply-To: <20190412141841.GA6235@sirena.org.uk> References: <20190411192814.10663-1-pierre-louis.bossart@linux.intel.com> <20190411192814.10663-2-pierre-louis.bossart@linux.intel.com> <20190412141841.GA6235@sirena.org.uk> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 12 Apr 2019 16:18:41 +0200, Mark Brown wrote: > > On Fri, Apr 12, 2019 at 09:07:41AM -0500, Pierre-Louis Bossart wrote: > > > config CODEC_XYX_SDW > > tristate "XYZ SDW Codec" > > depends on SOUNDWIRE > > select REGMAP_SOUNDWIRE > > That looks good. > > > config REGMAP_SOUNDWIRE > > select SOUNDWIRE_BUS > > > it'd follow the typical pattern seen in sound/soc/codecs/Kconfig: > > IIRC the select here won't actually do anything. I thought it'd do select SOUNDWIRE_BUS. The depends-on here would be ignored instead. Takashi