From: Takashi Iwai <tiwai@suse.de>
To: "Wenwen Wang" <wang6495@umn.edu>
Cc: "moderated list:SOUND" <alsa-devel@alsa-project.org>,
"Jaroslav Kysela" <perex@perex.cz>, "Kangjie Lu" <kjlu@umn.edu>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: control: fix a redundant-copy issue
Date: Sun, 13 May 2018 09:06:26 +0200 [thread overview]
Message-ID: <s5hvabs826l.wl-tiwai@suse.de> (raw)
In-Reply-To: <1525545485-12183-1-git-send-email-wang6495@umn.edu>
On Sat, 05 May 2018 20:38:03 +0200,
Wenwen Wang wrote:
>
> In snd_ctl_elem_add_compat(), the fields of the struct 'data' need to be
> copied from the corresponding fields of the struct 'data32' in userspace.
> This is achieved by invoking copy_from_user() and get_user() functions. The
> problem here is that the 'type' field is copied twice. One is by
> copy_from_user() and one is by get_user(). Given that the 'type' field is
> not used between the two copies, the second copy is *completely* redundant
> and should be removed for better performance and cleanup. Also, these two
> copies can cause inconsistent data: as the struct 'data32' resides in
> userspace and a malicious userspace process can race to change the 'type'
> field between the two copies to cause inconsistent data. Depending on how
> the data is used in the future, such an inconsistency may cause potential
> security risks.
>
> For above reasons, we should take out the second copy.
>
> Signed-off-by: Wenwen Wang <wang6495@umn.edu>
Applied now, thanks.
Takashi
prev parent reply other threads:[~2018-05-13 7:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-05 18:38 [PATCH] ALSA: control: fix a redundant-copy issue Wenwen Wang
2018-05-13 7:06 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hvabs826l.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=wang6495@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).