From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752607AbdLKRGf (ORCPT <rfc822;w@1wt.eu>);
        Mon, 11 Dec 2017 12:06:35 -0500
Received: from mx2.suse.de ([195.135.220.15]:52077 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750759AbdLKRGb (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 11 Dec 2017 12:06:31 -0500
Date: Mon, 11 Dec 2017 18:06:30 +0100
Message-ID: <s5hvahdjisp.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Vinod Koul <vinod.koul@intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        LKML <linux-kernel@vger.kernel.org>,
        ALSA <alsa-devel@alsa-project.org>, Mark <broonie@kernel.org>,
        Pierre <pierre-louis.bossart@linux.intel.com>, patches.audio@intel.com,
        alan@linux.intel.com, Charles Keepax <ckeepax@opensource.cirrus.com>,
        Sagar Dharia <sdharia@codeaurora.org>, srinivas.kandagatla@linaro.org,
        plai@codeaurora.org, Sudheer Papothi <spapothi@codeaurora.org>
Subject: Re: [PATCH v5 04/15] soundwire: Add MIPI DisCo property helpers
In-Reply-To: <20171211170022.GT18649@localhost>
References: <1512575231-4154-1-git-send-email-vinod.koul@intel.com>
        <1512575231-4154-5-git-send-email-vinod.koul@intel.com>
        <s5hbmj5kzyu.wl-tiwai@suse.de>
        <20171211170022.GT18649@localhost>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 11 Dec 2017 18:00:22 +0100,
Vinod Koul wrote:
> 
> On Mon, Dec 11, 2017 at 05:10:17PM +0100, Takashi Iwai wrote:
> > On Wed, 06 Dec 2017 16:47:00 +0100,
> > Vinod Koul wrote:
> > > 
> > > +		/* TODO: Read audio mode */
> > > +
> > > +		i++;
> > > +	}
> > 
> > Don't we use count argument for a sanity check?
> 
> Not really as that iterator runs on each bit:
> 
> for_each_set_bit(bit, &addr, 32) {
> 
> so it will not go on endlessly and can max out when all the bits being set
> and stop.

Yes, that shouldn't happen.  OTOH, only looking at the callee side,
one may wonder that the possible error would be dpn[] overflows the
given array size (=count).  Though, looking at both caller and callee,
one realizes that it shouldn't happen, too.
(But then again wonders why passing count argument at all :)


Takashi