From: Takashi Iwai <tiwai@suse.de>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Johannes Stezenbach <js@sig21.net>,
Hans de Goede <hdegoede@redhat.com>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 3/3] ACPI / PMIC: Add opregion driver for Intel Dollar Cove TI PMIC
Date: Fri, 25 Aug 2017 17:38:11 +0200 [thread overview]
Message-ID: <s5hvalbfyjg.wl-tiwai@suse.de> (raw)
In-Reply-To: <CAHp75VeuEcBpQ6qcH+c=GYgNndjoLEn=C9NSJvOcYVgraOLWkQ@mail.gmail.com>
On Fri, 25 Aug 2017 17:24:19 +0200,
Andy Shevchenko wrote:
>
> On Fri, Aug 25, 2017 at 4:44 PM, Takashi Iwai <tiwai@suse.de> wrote:
>
> One really minor nit (fine if it will be ignored):
>
> > +config CHTDC_TI_PMIC_OPREGION
>
> CHTDC_TI_PMIC_OPREGION -> CHT_DC_TI_PMIC_OPREGION
Ah, the world is inconsistent...
> > obj-$(CONFIG_XPOWER_PMIC_OPREGION) += pmic/intel_pmic_xpower.o
> > obj-$(CONFIG_BXT_WC_PMIC_OPREGION) += pmic/intel_pmic_bxtwc.o
> > obj-$(CONFIG_CHT_WC_PMIC_OPREGION) += pmic/intel_pmic_chtwc.o
> > +obj-$(CONFIG_CHTDC_TI_PMIC_OPREGION) += pmic/intel_pmic_chtdc_ti.o
>
> Ditto (as you can notice by above context).
... where the file name is combined.
I really don't mind, too.
Rafael, please let me know if you want a resubmission with this
correction.
thanks,
Takashi
next prev parent reply other threads:[~2017-08-25 15:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-25 13:44 [PATCH v3 0/3] Dollar Cove TI PMIC support for Intel Cherry Trail Takashi Iwai
2017-08-25 13:44 ` [PATCH v3 1/3] mfd: Add support for Cherry Trail Dollar Cove TI PMIC Takashi Iwai
2017-08-28 22:31 ` Rafael J. Wysocki
2017-08-29 5:15 ` Takashi Iwai
2017-08-25 13:44 ` [PATCH v3 2/3] platform/x86: Add support for Dollar Cove TI power button Takashi Iwai
2017-08-25 13:44 ` [PATCH v3 3/3] ACPI / PMIC: Add opregion driver for Intel Dollar Cove TI PMIC Takashi Iwai
2017-08-25 15:24 ` Andy Shevchenko
2017-08-25 15:38 ` Takashi Iwai [this message]
2017-08-26 12:52 ` Rafael J. Wysocki
2017-08-28 6:50 ` [PATCH v4] " Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hvalbfyjg.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=hdegoede@redhat.com \
--cc=js@sig21.net \
--cc=lee.jones@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).