From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933633AbcFQPAM (ORCPT ); Fri, 17 Jun 2016 11:00:12 -0400 Received: from mx2.suse.de ([195.135.220.15]:50716 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932065AbcFQPAK (ORCPT ); Fri, 17 Jun 2016 11:00:10 -0400 Date: Fri, 17 Jun 2016 17:00:03 +0200 Message-ID: From: Takashi Iwai To: "Amitoj Kaur Chawla" Cc: , , , , , Subject: Re: [PATCH v2] ALSA: usb-audio: Change structure initialisation to C99 style In-Reply-To: <20160617144215.GA17151@amitoj-Inspiron-3542> References: <20160617144215.GA17151@amitoj-Inspiron-3542> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 17 Jun 2016 16:42:15 +0200, Amitoj Kaur Chawla wrote: > > To allow for structure randomisation, replace the in order struct > initialisation style with explicit field style. > > The Coccinelle semantic patch used to make this change is as follows: > > @decl@ > identifier i1,fld; > type T; > field list[n] fs; > @@ > > struct i1 { > fs > T fld; > ...}; > > @@ > identifier decl.i1,i2,decl.fld; > expression e; > position bad.p, bad.fix; > @@ > > struct i1 i2@p = { ..., > + .fld = e > - e@fix > ,...}; > > Signed-off-by: Amitoj Kaur Chawla > --- > Changes in v2: > -Modified commit message Applied, thanks. Takashi