From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751885AbaLCGvX (ORCPT ); Wed, 3 Dec 2014 01:51:23 -0500 Received: from cantor2.suse.de ([195.135.220.15]:49730 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751374AbaLCGvV (ORCPT ); Wed, 3 Dec 2014 01:51:21 -0500 Date: Wed, 03 Dec 2014 07:51:20 +0100 Message-ID: From: Takashi Iwai To: SF Markus Elfring Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH 0/2] ALSA: ctxfi: Delete an unnecessary check before kfree() In-Reply-To: <547E2612.6010304@users.sourceforge.net> References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <547E2612.6010304@users.sourceforge.net> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.4 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Tue, 02 Dec 2014 21:50:26 +0100, SF Markus Elfring wrote: > > From: Markus Elfring > Date: Tue, 2 Dec 2014 20:35:41 +0100 > > Another update suggestion was taken into account after a patch was applied > from static source code analysis. > > Markus Elfring (2): > Deletion of an unnecessary check before the function call "kfree" > One function call less in get_daio_rsc() after error detection In these cases, the changes aren't so straightforward, and they don't improve the readability. Takashi