From: Takashi Iwai <tiwai@suse.de>
To: minyard@acm.org
Cc: Patrick Vo <patrick.vo@hpe.com>,
openipmi-developer@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipmi_si: Avoid spurious errors for optional IRQs
Date: Thu, 13 Feb 2020 14:28:49 +0100 [thread overview]
Message-ID: <s5hwo8qlipa.wl-tiwai@suse.de> (raw)
In-Reply-To: <20200213130212.GP7842@minyard.net>
On Thu, 13 Feb 2020 14:02:12 +0100,
Corey Minyard wrote:
>
> On Thu, Feb 13, 2020 at 09:34:12AM +0100, Takashi Iwai wrote:
> > On Wed, 05 Feb 2020 10:31:46 +0100,
> > Takashi Iwai wrote:
> > >
> > > Although the IRQ assignment in ipmi_si driver is optional,
> > > platform_get_irq() spews error messages unnecessarily:
> > > ipmi_si dmi-ipmi-si.0: IRQ index 0 not found
> > >
> > > Fix this by switching to platform_get_irq_optional().
> > >
> > > Fixes: 7723f4c5ecdb ("driver core: platform: Add an error message to platform_get_irq*()")
> > > Reported-and-tested-by: Patrick Vo <patrick.vo@hpe.com>
> > > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> >
> > Any review / ack on this?
>
> Sorry, lost in the noise. I've included this for 5.7. If you want it
> earlier, I can arrange that.
It's fine for 5.7, as it's no urgent fix at all. Thanks!
Takashi
>
> Thanks,
>
> -corey
>
> >
> >
> > thanks,
> >
> > Takashi
> >
> > > ---
> > > drivers/char/ipmi/ipmi_si_platform.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/char/ipmi/ipmi_si_platform.c b/drivers/char/ipmi/ipmi_si_platform.c
> > > index c78127ccbc0d..638c693e17ad 100644
> > > --- a/drivers/char/ipmi/ipmi_si_platform.c
> > > +++ b/drivers/char/ipmi/ipmi_si_platform.c
> > > @@ -194,7 +194,7 @@ static int platform_ipmi_probe(struct platform_device *pdev)
> > > else
> > > io.slave_addr = slave_addr;
> > >
> > > - io.irq = platform_get_irq(pdev, 0);
> > > + io.irq = platform_get_irq_optional(pdev, 0);
> > > if (io.irq > 0)
> > > io.irq_setup = ipmi_std_irq_setup;
> > > else
> > > @@ -378,7 +378,7 @@ static int acpi_ipmi_probe(struct platform_device *pdev)
> > > io.irq = tmp;
> > > io.irq_setup = acpi_gpe_irq_setup;
> > > } else {
> > > - int irq = platform_get_irq(pdev, 0);
> > > + int irq = platform_get_irq_optional(pdev, 0);
> > >
> > > if (irq > 0) {
> > > io.irq = irq;
> > > --
> > > 2.16.4
> > >
>
prev parent reply other threads:[~2020-02-13 13:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 9:31 [PATCH] ipmi_si: Avoid spurious errors for optional IRQs Takashi Iwai
2020-02-13 8:34 ` Takashi Iwai
2020-02-13 13:02 ` Corey Minyard
2020-02-13 13:28 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hwo8qlipa.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=patrick.vo@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).